Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: src/isolate.h

Issue 2578173004: [promisehook] Fire init hook for promise subclass (Closed)
Patch Set: Fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-promise.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 36c22bbddd18f4342ed42dd3b4d11fccd4dab9f0..652a60b0b8450fa7a148571895a71e2ab190ba33 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -1129,7 +1129,7 @@ class Isolate {
return reinterpret_cast<Address>(&promise_hook_);
}
void SetPromiseHook(PromiseHook hook);
- void RunPromiseHook(PromiseHookType type, Handle<JSPromise> promise,
+ void RunPromiseHook(PromiseHookType type, Handle<JSObject> promise,
Dan Ehrenberg 2016/12/20 22:45:18 I don't see how the promise here would not be a JS
gsathya 2016/12/20 23:47:26 You're right. I was under the wrong impression tha
Handle<Object> parent);
// Support for dynamically disabling tail call elimination.
« no previous file with comments | « src/builtins/builtins-promise.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698