Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2578133002: [turbofan] fixed escape analysis bug: missing copy of virtual state (Closed)

Created:
4 years ago by Tobias Tebbi
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] fixed escape analysis bug: missing copy of virtual state R=jarin@chromium.org BUG=chromium:673243 Review-Url: https://codereview.chromium.org/2578133002 Cr-Commit-Position: refs/heads/master@{#41848} Committed: https://chromium.googlesource.com/v8/v8/+/abd63018d7db329b3e702c01799d5136d600bcfa

Patch Set 1 #

Patch Set 2 : added test #

Total comments: 2

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M src/compiler/escape-analysis.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A test/mjsunit/compiler/escape-analysis-framestate-use-at-branchpoint.js View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Tobias Tebbi
4 years ago (2016-12-15 14:17:07 UTC) #3
Jarin
Great catch! Please add the test. Also use "BUG=chromium:nnnnnn" rather than "BUG=nnnnnn" so that it ...
4 years ago (2016-12-15 14:30:10 UTC) #4
Tobias Tebbi
4 years ago (2016-12-15 14:52:54 UTC) #6
Jarin
lgtm https://codereview.chromium.org/2578133002/diff/60001/test/mjsunit/compiler/escape-analysis-framestate-use-at-branchpoint.js File test/mjsunit/compiler/escape-analysis-framestate-use-at-branchpoint.js (right): https://codereview.chromium.org/2578133002/diff/60001/test/mjsunit/compiler/escape-analysis-framestate-use-at-branchpoint.js#newcode1 test/mjsunit/compiler/escape-analysis-framestate-use-at-branchpoint.js:1: // Copyright 2013 the V8 project authors. All ...
4 years ago (2016-12-19 07:28:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578133002/80001
4 years ago (2016-12-20 10:02:58 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 10:30:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/abd63018d7db329b3e702c01799d5136d60...

Powered by Google App Engine
This is Rietveld 408576698