Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h
diff --git a/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h b/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h
index 7d7a03837c6b268512f4d9e6aa2df5f85500df17..be587dec71465095e7e7b6717a1429d6b3ef1f93 100644
--- a/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h
+++ b/tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h
@@ -11,21 +11,21 @@ namespace blink {
class X : public GarbageCollected<X> {
public:
- void trace(Visitor*) {}
- void trace(InlinedGlobalMarkingVisitor) {}
+ void Trace(Visitor*) {}
+ void Trace(InlinedGlobalMarkingVisitor) {}
};
class InlinedBase : public GarbageCollected<InlinedBase> {
public:
- virtual void trace(Visitor* visitor) { traceImpl(visitor); }
- virtual void trace(InlinedGlobalMarkingVisitor visitor) {
- traceImpl(visitor);
+ virtual void Trace(Visitor* visitor) { TraceImpl(visitor); }
+ virtual void Trace(InlinedGlobalMarkingVisitor visitor) {
+ TraceImpl(visitor);
}
private:
template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
- // Missing visitor->trace(x_base_).
+ void TraceImpl(VisitorDispatcher visitor) {
+ // Missing visitor->Trace(x_base_).
}
Member<X> x_base_;
@@ -33,15 +33,15 @@ class InlinedBase : public GarbageCollected<InlinedBase> {
class InlinedDerived : public InlinedBase {
public:
- void trace(Visitor* visitor) override { traceImpl(visitor); }
- void trace(InlinedGlobalMarkingVisitor visitor) override {
- traceImpl(visitor);
+ void Trace(Visitor* visitor) override { TraceImpl(visitor); }
+ void Trace(InlinedGlobalMarkingVisitor visitor) override {
+ TraceImpl(visitor);
}
private:
template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher visitor) {
- // Missing visitor->trace(x_derived_) and InlinedBase::trace(visitor).
+ void TraceImpl(VisitorDispatcher visitor) {
+ // Missing visitor->Trace(x_derived_) and InlinedBase::Trace(visitor).
}
Member<X> x_derived_;
@@ -49,24 +49,24 @@ class InlinedDerived : public InlinedBase {
class ExternBase : public GarbageCollected<ExternBase> {
public:
- virtual void trace(Visitor*);
- virtual void trace(InlinedGlobalMarkingVisitor);
+ virtual void Trace(Visitor*);
+ virtual void Trace(InlinedGlobalMarkingVisitor);
private:
template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher);
+ void TraceImpl(VisitorDispatcher);
Member<X> x_base_;
};
class ExternDerived : public ExternBase {
public:
- void trace(Visitor*) override;
- void trace(InlinedGlobalMarkingVisitor) override;
+ void Trace(Visitor*) override;
+ void Trace(InlinedGlobalMarkingVisitor) override;
private:
template <typename VisitorDispatcher>
- void traceImpl(VisitorDispatcher);
+ void TraceImpl(VisitorDispatcher);
Member<X> x_derived_;
};

Powered by Google App Engine
This is Rietveld 408576698