Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Side by Side Diff: tools/clang/blink_gc_plugin/tests/traceimpl_overloaded_error.h

Issue 2578103003: Add use-chromium-style-naming option to Blink GC plugin. (Closed)
Patch Set: Rebase Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TRACEIMPL_OVERLOADED_ERROR_H_ 5 #ifndef TRACEIMPL_OVERLOADED_ERROR_H_
6 #define TRACEIMPL_OVERLOADED_ERROR_H_ 6 #define TRACEIMPL_OVERLOADED_ERROR_H_
7 7
8 #include "heap/stubs.h" 8 #include "heap/stubs.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class X : public GarbageCollected<X> { 12 class X : public GarbageCollected<X> {
13 public: 13 public:
14 void trace(Visitor*) {} 14 void Trace(Visitor*) {}
15 void trace(InlinedGlobalMarkingVisitor) {} 15 void Trace(InlinedGlobalMarkingVisitor) {}
16 }; 16 };
17 17
18 class InlinedBase : public GarbageCollected<InlinedBase> { 18 class InlinedBase : public GarbageCollected<InlinedBase> {
19 public: 19 public:
20 virtual void trace(Visitor* visitor) { traceImpl(visitor); } 20 virtual void Trace(Visitor* visitor) { TraceImpl(visitor); }
21 virtual void trace(InlinedGlobalMarkingVisitor visitor) { 21 virtual void Trace(InlinedGlobalMarkingVisitor visitor) {
22 traceImpl(visitor); 22 TraceImpl(visitor);
23 } 23 }
24 24
25 private: 25 private:
26 template <typename VisitorDispatcher> 26 template <typename VisitorDispatcher>
27 void traceImpl(VisitorDispatcher visitor) { 27 void TraceImpl(VisitorDispatcher visitor) {
28 // Missing visitor->trace(x_base_). 28 // Missing visitor->Trace(x_base_).
29 } 29 }
30 30
31 Member<X> x_base_; 31 Member<X> x_base_;
32 }; 32 };
33 33
34 class InlinedDerived : public InlinedBase { 34 class InlinedDerived : public InlinedBase {
35 public: 35 public:
36 void trace(Visitor* visitor) override { traceImpl(visitor); } 36 void Trace(Visitor* visitor) override { TraceImpl(visitor); }
37 void trace(InlinedGlobalMarkingVisitor visitor) override { 37 void Trace(InlinedGlobalMarkingVisitor visitor) override {
38 traceImpl(visitor); 38 TraceImpl(visitor);
39 } 39 }
40 40
41 private: 41 private:
42 template <typename VisitorDispatcher> 42 template <typename VisitorDispatcher>
43 void traceImpl(VisitorDispatcher visitor) { 43 void TraceImpl(VisitorDispatcher visitor) {
44 // Missing visitor->trace(x_derived_) and InlinedBase::trace(visitor). 44 // Missing visitor->Trace(x_derived_) and InlinedBase::Trace(visitor).
45 } 45 }
46 46
47 Member<X> x_derived_; 47 Member<X> x_derived_;
48 }; 48 };
49 49
50 class ExternBase : public GarbageCollected<ExternBase> { 50 class ExternBase : public GarbageCollected<ExternBase> {
51 public: 51 public:
52 virtual void trace(Visitor*); 52 virtual void Trace(Visitor*);
53 virtual void trace(InlinedGlobalMarkingVisitor); 53 virtual void Trace(InlinedGlobalMarkingVisitor);
54 54
55 private: 55 private:
56 template <typename VisitorDispatcher> 56 template <typename VisitorDispatcher>
57 void traceImpl(VisitorDispatcher); 57 void TraceImpl(VisitorDispatcher);
58 58
59 Member<X> x_base_; 59 Member<X> x_base_;
60 }; 60 };
61 61
62 class ExternDerived : public ExternBase { 62 class ExternDerived : public ExternBase {
63 public: 63 public:
64 void trace(Visitor*) override; 64 void Trace(Visitor*) override;
65 void trace(InlinedGlobalMarkingVisitor) override; 65 void Trace(InlinedGlobalMarkingVisitor) override;
66 66
67 private: 67 private:
68 template <typename VisitorDispatcher> 68 template <typename VisitorDispatcher>
69 void traceImpl(VisitorDispatcher); 69 void TraceImpl(VisitorDispatcher);
70 70
71 Member<X> x_derived_; 71 Member<X> x_derived_;
72 }; 72 };
73 73
74 } 74 }
75 75
76 #endif // TRACEIMPL_OVERLOADED_ERROR_H_ 76 #endif // TRACEIMPL_OVERLOADED_ERROR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698