Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2578063002: Remove dead code in password_manager.js (Closed)

Created:
4 years ago by vabr (Chromium)
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, gcasto+watchlist_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code in password_manager.js The method setManageAccountLinkVisibility_ was removed in https://codereview.chromium.org/1396403004 but slipped back in during a wrong rebase in https://codereview.chromium.org/1193143003. The method is not referenced anywhere, it is an easy case of ded code. This CL removes that method. BUG=480552 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9f5c4538a12063abdd4bbebda71a1ab3fecf845d Cr-Commit-Position: refs/heads/master@{#439082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/resources/options/password_manager.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
vabr (Chromium)
Hi Steven, Please take a look. Thanks, Vaclav
4 years ago (2016-12-15 08:09:16 UTC) #5
stevenjb
lgtm
4 years ago (2016-12-15 18:33:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578063002/1
4 years ago (2016-12-16 08:15:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 10:03:00 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-16 10:06:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f5c4538a12063abdd4bbebda71a1ab3fecf845d
Cr-Commit-Position: refs/heads/master@{#439082}

Powered by Google App Engine
This is Rietveld 408576698