Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2578053003: [modules] Remove @@iterator on namespace objects. (Closed)

Created:
4 years ago by neis
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, rmcilroy, gsathya
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Remove @@iterator on namespace objects. TC39 decided at their last meeting to remove this feature. R=adamk@chromium.org TBR=ulan@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2578053003 Cr-Commit-Position: refs/heads/master@{#41745} Committed: https://chromium.googlesource.com/v8/v8/+/e3ad4f131b9453252f77f20046427959acf8d939

Patch Set 1 #

Patch Set 2 : Skip out-of-date tests262 tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -223 lines) Patch
M src/ast/ast-types.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 3 chunks +1 line, -30 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins/builtins-iterator.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M src/compiler/types.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 5 chunks +0 lines, -35 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-debug.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M src/objects-inl.h View 4 chunks +0 lines, -8 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/modules-namespace1.js View 2 chunks +1 line, -36 lines 0 comments Download
M test/mjsunit/modules-namespace2.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
neis
4 years ago (2016-12-15 16:03:29 UTC) #1
neis
ptal @gsathya, fyi :)
4 years ago (2016-12-15 16:04:28 UTC) #3
Benedikt Meurer (Google)
On 2016/12/15 16:04:28, neis wrote: > ptal > > @gsathya, fyi :) LGTM
4 years ago (2016-12-15 16:13:48 UTC) #4
adamk
lgtm
4 years ago (2016-12-15 17:13:24 UTC) #9
adamk
Looks like there are some test262 tests that need skipping until they're removed from the ...
4 years ago (2016-12-15 17:14:03 UTC) #10
Benedikt Meurer
LGTM (this time with the correct account), thanks!
4 years ago (2016-12-15 19:31:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578053003/20001
4 years ago (2016-12-16 08:27:21 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-16 08:57:38 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e3ad4f131b9453252f77f20046427959acf...

Powered by Google App Engine
This is Rietveld 408576698