Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1684)

Unified Diff: Source/web/WebDOMActivityLogger.cpp

Issue 257803006: Fixing wrong extension ID in Activity Log entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: typo Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebDOMActivityLogger.cpp
diff --git a/Source/web/WebDOMActivityLogger.cpp b/Source/web/WebDOMActivityLogger.cpp
index ef7a085458eedbe83beea603f1f5a0dd332bd8b6..9d888203ba93312501e4dfc4f1dc0ccf2085fa5b 100644
--- a/Source/web/WebDOMActivityLogger.cpp
+++ b/Source/web/WebDOMActivityLogger.cpp
@@ -64,15 +64,28 @@ private:
OwnPtr<WebDOMActivityLogger> m_domActivityLogger;
};
+bool hasDOMActivityLogger(int worldId, const WebString& extensionId)
+{
+ return V8DOMActivityLogger::activityLogger(worldId, extensionId);
+}
+
+void setDOMActivityLogger(int worldId, const WebString& extensionId, WebDOMActivityLogger* logger)
+{
+ ASSERT(logger);
+ V8DOMActivityLogger::setActivityLogger(worldId, extensionId, adoptPtr(new DOMActivityLoggerContainer(adoptPtr(logger))));
+}
+
+// TODO(pmarch): remove the following two methods after modifying Chrome to
+// use the above ones.
bool hasDOMActivityLogger(int worldId)
{
- return V8DOMActivityLogger::activityLogger(worldId);
+ return V8DOMActivityLogger::activityLogger(worldId, WebString());
}
void setDOMActivityLogger(int worldId, WebDOMActivityLogger* logger)
{
ASSERT(logger);
- V8DOMActivityLogger::setActivityLogger(worldId, adoptPtr(new DOMActivityLoggerContainer(adoptPtr(logger))));
+ V8DOMActivityLogger::setActivityLogger(worldId, WebString(), adoptPtr(new DOMActivityLoggerContainer(adoptPtr(logger))));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698