Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 257803006: Fixing wrong extension ID in Activity Log entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: typo Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8WindowShell.cpp
diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp
index 6511b9da2daafabe70158fb73ce2e616d9a05374..df146e8055ec03f507c2be3aa20125b4bd76c326 100644
--- a/Source/bindings/v8/V8WindowShell.cpp
+++ b/Source/bindings/v8/V8WindowShell.cpp
@@ -212,7 +212,9 @@ bool V8WindowShell::initialize()
setInjectedScriptContextDebugId(context, m_frame->script().contextDebugId(mainWindow->context()));
}
- m_scriptState->perContextData()->setActivityLogger(V8DOMActivityLogger::activityLogger(m_world->worldId()));
+ m_scriptState->perContextData()->setActivityLogger(
haraken 2014/04/30 00:54:20 It's mis-designed that ActivityLogger is cached on
+ V8DOMActivityLogger::activityLogger(m_world->worldId(),
+ m_frame->document() ? m_frame->document()->baseURI() : KURL()));
if (!installDOMWindow()) {
disposeContext(DoNotDetachGlobal);
return false;

Powered by Google App Engine
This is Rietveld 408576698