content/browser/service_worker/embedded_worker_instance.h - Issue 2578023002: ServiceWorker: Stop don't send a message before connection established

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 2578023002: ServiceWorker: Stop don't send a message before connection established (Closed)

Patch Set: Reset starting_phase when releasing the process Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/embedded_worker_instance.h

diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h

index 01e2b02e183766bab42d9b9fce9212caa2f43793..3152613ed3880f16bb4257d6a749902629d2d872 100644

--- a/content/browser/service_worker/embedded_worker_instance.h

+++ b/content/browser/service_worker/embedded_worker_instance.h

@@ -114,9 +114,8 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {

// Stops the worker. It is invalid to call this when the worker is

// not in STARTING or RUNNING status.

- // This returns false if stopping a worker fails immediately, e.g. when

- // IPC couldn't be sent to the worker.

- ServiceWorkerStatusCode Stop();

+ // This returns false when StopWorker IPC couldn't be sent to the worker.

+ bool Stop();

// Stops the worker if the worker is not being debugged (i.e. devtools is

// not attached). This method is called by a stop-worker timer to kill