Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2578023002: ServiceWorker: Stop don't send a message before connection established (Closed)
Patch Set: Reset starting_phase when releasing the process Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « content/renderer/service_worker/embedded_worker_instance_client_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 48eff2959d0aaf43dcac2f469cea5d33ccfdbbbb..57ef3cf613c067703cf3a32dcb4899a004990b04 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -59364,6 +59364,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>
The result of trying to send the IPC message to a renderer process telling
it to stop an embedded worker. Recorded in EmbeddedWorkerInstance::Stop.
+ This was previously recorded for both the IPC and Mojo service worker
Mark P 2017/01/05 20:11:08 A better practice would be to rename the current S
falken 2017/01/06 02:14:54 The IPC implementation is already off by default (
Mark P 2017/01/06 04:52:43 Thanks for the explanation. In this case--it's ef
shimazu 2017/01/06 04:58:23 Thanks for your comments. I'll commit as is (ps11)
+ implementations, but as of Jan 2017, this is only recorded for the IPC
+ implementation. This histogram will be removed after the IPC implementation
+ is removed.
</summary>
</histogram>
« no previous file with comments | « content/renderer/service_worker/embedded_worker_instance_client_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698