Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2577963007: lcms: Sanitize floating point read (Closed)

Created:
4 years ago by kcwu
Modified:
4 years ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : lcms: Sanitize floating point read #

Total comments: 2

Patch Set 3 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A third_party/lcms2-2.6/0015-sanitize-float-read.patch View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/lcms2-2.6/README.pdfium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/lcms2-2.6/src/cmsplugin.c View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kcwu
With this CL, https://codereview.chromium.org/2422553002 is redundant. I will create another CL to remove it. Let ...
4 years ago (2016-12-16 16:00:35 UTC) #2
Tom Sepez
LGTM, feel free to do removal in another CL once this sticks. As always, when ...
4 years ago (2016-12-16 18:27:34 UTC) #3
kcwu
https://codereview.chromium.org/2577963007/diff/20001/third_party/lcms2-2.6/src/cmsplugin.c File third_party/lcms2-2.6/src/cmsplugin.c (right): https://codereview.chromium.org/2577963007/diff/20001/third_party/lcms2-2.6/src/cmsplugin.c#newcode187 third_party/lcms2-2.6/src/cmsplugin.c:187: return ((fpclassify(*n) == FP_ZERO) || (fpclassify(*n) == FP_NORMAL)); On ...
4 years ago (2016-12-17 03:32:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577963007/40001
4 years ago (2016-12-17 03:32:15 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-17 03:42:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/da587fab57602e5e10c058e6e632df513fba...

Powered by Google App Engine
This is Rietveld 408576698