DevTools: convert UI.ComboBoxFilterUI to use vanilla <select> element

DevTools: convert UI.ComboBoxFilterUI to use vanilla <select> element

Currently, the UI.ComboBoxFilterUI uses UI.ToolbarComboBox for the select
element. However, the component should be used only as a toolbar child,
since the toolbar has a bunch of CSS for the component.

This patch migrates UI.ComboBoxFilterUI from UI.ToolbarComboBox to a
simple <select>

BUG=674463
R=dgozman

Committed: https://crrev.com/09ad7587e22ccd1c7ab3ecc6ed5be054618e90b3
Cr-Commit-Position: refs/heads/master@{#438998}

[lushnikov, 2016-12-15 21:27:09]

please, take a look

[lushnikov, 2016-12-15 21:27:19]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 21:28:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-12-15 22:58:09]

lgtm

https://codereview.chromium.org/2577953004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js (right):

https://codereview.chromium.org/2577953004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js:494:
this._filterComboBox = createElement('select');
Try the .chrome-select class, it will look like settings combo box?

[lushnikov, 2016-12-15 23:09:44]

https://codereview.chromium.org/2577953004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js (right):

https://codereview.chromium.org/2577953004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js:494:
this._filterComboBox = createElement('select');
On 2016/12/15 22:58:09, dgozman wrote:
> Try the .chrome-select class, it will look like settings combo box?

Done. Looks better.

[lushnikov, 2016-12-15 23:09:47]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-15 23:09:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2577953004/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2016-12-15 23:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 03:16:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481843387746800,
"parent_rev": "f260bfcbd9c03a06124ee1eafdfc7ae2148a8907", "commit_rev":
"2a8bd1cfa9fd78339678c4791128a77e96e1c7a7"}

[commit-bot: I haz the power, 2016-12-16 03:16:47]

Description was changed from

==========
DevTools: convert UI.ComboBoxFilterUI to use vanilla <select> element

Currently, the UI.ComboBoxFilterUI uses UI.ToolbarComboBox for the select
element. However, the component should be used only as a toolbar child,
since the toolbar has a bunch of CSS for the component.

This patch migrates UI.ComboBoxFilterUI from UI.ToolbarComboBox to a
simple <select>

BUG=674463
R=dgozman
==========

to

==========
DevTools: convert UI.ComboBoxFilterUI to use vanilla <select> element

Currently, the UI.ComboBoxFilterUI uses UI.ToolbarComboBox for the select
element. However, the component should be used only as a toolbar child,
since the toolbar has a bunch of CSS for the component.

This patch migrates UI.ComboBoxFilterUI from UI.ToolbarComboBox to a
simple <select>

BUG=674463
R=dgozman

Review-Url: https://codereview.chromium.org/2577953004
==========

[commit-bot: I haz the power, 2016-12-16 03:16:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-16 03:20:26]

Description was changed from

==========
DevTools: convert UI.ComboBoxFilterUI to use vanilla <select> element

Currently, the UI.ComboBoxFilterUI uses UI.ToolbarComboBox for the select
element. However, the component should be used only as a toolbar child,
since the toolbar has a bunch of CSS for the component.

This patch migrates UI.ComboBoxFilterUI from UI.ToolbarComboBox to a
simple <select>

BUG=674463
R=dgozman

Review-Url: https://codereview.chromium.org/2577953004
==========

to

==========
DevTools: convert UI.ComboBoxFilterUI to use vanilla <select> element

Currently, the UI.ComboBoxFilterUI uses UI.ToolbarComboBox for the select
element. However, the component should be used only as a toolbar child,
since the toolbar has a bunch of CSS for the component.

This patch migrates UI.ComboBoxFilterUI from UI.ToolbarComboBox to a
simple <select>

BUG=674463
R=dgozman

Committed: https://crrev.com/09ad7587e22ccd1c7ab3ecc6ed5be054618e90b3
Cr-Commit-Position: refs/heads/master@{#438998}
==========

[commit-bot: I haz the power, 2016-12-16 03:20:27]

Patchset 2 (id:??) landed as
https://crrev.com/09ad7587e22ccd1c7ab3ecc6ed5be054618e90b3
Cr-Commit-Position: refs/heads/master@{#438998}