Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2577923004: Whitelist new member names of RTCIceCandidatePairStats. (Closed)

Created:
4 years ago by hbos_chromium
Modified:
4 years ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist new member names of RTCIceCandidatePairStats. totalRtt and currentRtt have been renamed in the spec to totalRoundTripTime and currentRoundTripTime: https://w3c.github.io/webrtc-stats/#since-21-sep-2016* Both old and new names are whitelisted until https://codereview.webrtc.org/2576383002/ has rolled into Chromium. When the roll is done old names will be removed. BUG=chromium:627816 Committed: https://crrev.com/3b9eb7452508f0adec7ae4bedc1bc9350e2e224d Cr-Commit-Position: refs/heads/master@{#438808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/test/data/webrtc/peerconnection_getstats.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
hbos_chromium
Please take a looksies, phoglund.
4 years ago (2016-12-15 10:54:49 UTC) #2
phoglund_chromium
lgtm
4 years ago (2016-12-15 11:00:06 UTC) #5
phoglund_chromium
we lgtms the patchsies. Yessss-ss. We trust nice patch authorses.
4 years ago (2016-12-15 11:01:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577923004/1
4 years ago (2016-12-15 11:02:03 UTC) #9
hbos_chromium
On 2016/12/15 11:01:25, phoglund_chrome wrote: > we lgtms the patchsies. Yessss-ss. We trust nice patch ...
4 years ago (2016-12-15 11:02:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 11:54:04 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 11:56:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b9eb7452508f0adec7ae4bedc1bc9350e2e224d
Cr-Commit-Position: refs/heads/master@{#438808}

Powered by Google App Engine
This is Rietveld 408576698