Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2577913002: Apply error processors in the new driver (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M pkg/analysis_server/lib/src/computer/new_notifications.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 6 chunks +29 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years ago (2016-12-14 23:48:06 UTC) #2
scheglov
LGTM
4 years ago (2016-12-15 00:06:14 UTC) #3
Brian Wilkerson
4 years ago (2016-12-15 00:07:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c946a6b9b33d11d2d3bf46167d6f0f826cbda13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698