Apply error processors in the new driver

pkg/analysis_server/test/analysis/notification_analysis_options_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.analysis.notification_analysis_options_test;
 
 import 'package:analysis_server/plugin/protocol/protocol.dart'
     hide AnalysisOptions;
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/domain_analysis.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:linter/src/rules.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../analysis_abstract.dart';
 import '../mocks.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(NewAnalysisOptionsFileNotificationTest);
     defineReflectiveTests(OldAnalysisOptionsFileNotificationTest);
-    // These tests all fail, presumably because we are not updating the analysis
-    // options when the file changes and because we are not analyzing the
-    // analysis options file.
-//    defineReflectiveTests(NewAnalysisOptionsFileNotificationTest_Driver);
-//    defineReflectiveTests(OldAnalysisOptionsFileNotificationTest_Driver);
+    defineReflectiveTests(NewAnalysisOptionsFileNotificationTest_Driver);
+    defineReflectiveTests(OldAnalysisOptionsFileNotificationTest_Driver);
   });
 }
 
 abstract class AnalysisOptionsFileNotificationTest
     extends AbstractAnalysisTest {
   Map<String, List<AnalysisError>> filesErrors = {};
 
   final testSource = '''
 main() {
   var x = '';
@@ skipping 63 matching lines @@
 main() {
   String unused = "";
 }
 ''');
 
     setAnalysisRoot();
 
     await waitForTasksFinished();
 
     // Verify options file.
-    expect(optionsFileErrors, isNotNull);
-    expect(optionsFileErrors, isEmpty);
+    if (!enableNewAnalysisDriver) {
+      // TODO(brianwilkerson) Implement options file analysis in the new driver.
+      expect(optionsFileErrors, isNotNull);
+      expect(optionsFileErrors, isEmpty);
+    }
 
     // Verify test file.
     expect(testFileErrors, isNotNull);
     expect(testFileErrors, isEmpty);
   }
 
   test_error_filter_removed() async {
     addOptionsFile('''
 analyzer:
   errors:
     unused_local_variable: ignore
 ''');
 
     addTestFile('''
 main() {
   String unused = "";
 }
 ''');
 
     setAnalysisRoot();
 
     await waitForTasksFinished();
 
     // Verify options file.
-    expect(optionsFileErrors, isNotNull);
-    expect(optionsFileErrors, isEmpty);
+    if (!enableNewAnalysisDriver) {
+      // TODO(brianwilkerson) Implement options file analysis in the new driver.
+      expect(optionsFileErrors, isNotNull);
+      expect(optionsFileErrors, isEmpty);
+    }
 
     // Verify test file.
     expect(testFileErrors, isNotNull);
     expect(testFileErrors, isEmpty);
 
     addOptionsFile('''
 analyzer:
   errors:
   #  unused_local_variable: ignore
 ''');
 
     await pumpEventQueue();
     await waitForTasksFinished();
 
     // Verify options file.
-    expect(optionsFileErrors, isEmpty);
+    if (!enableNewAnalysisDriver) {
+      // TODO(brianwilkerson) Implement options file analysis in the new driver.
+      expect(optionsFileErrors, isEmpty);
+    }
 
     // Verify test file.
     expect(testFileErrors, hasLength(1));
   }
 
   test_lint_options_changes() async {
     addOptionsFile('''
 linter:
   rules:
     - camel_case_types
@@ skipping 24 matching lines @@
 linter:
   rules:
     - unsupported
 ''');
 
     addTestFile(testSource);
     setAnalysisRoot();
 
     await waitForTasksFinished();
 
-    expect(optionsFileErrors, hasLength(1));
-    expect(optionsFileErrors.first.severity, AnalysisErrorSeverity.WARNING);
-    expect(optionsFileErrors.first.type, AnalysisErrorType.STATIC_WARNING);
+    if (!enableNewAnalysisDriver) {
+      // TODO(brianwilkerson) Implement options file analysis in the new driver.
+      expect(optionsFileErrors, hasLength(1));
+      expect(optionsFileErrors.first.severity, AnalysisErrorSeverity.WARNING);
+      expect(optionsFileErrors.first.type, AnalysisErrorType.STATIC_WARNING);
+    }
   }
 
   test_options_file_added() async {
     addTestFile(testSource);
     setAnalysisRoot();
 
     await waitForTasksFinished();
 
     // Verify strong-mode disabled.
     verifyStrongMode(enabled: false);
@@ skipping 11 matching lines @@
   }
 
   test_options_file_parse_error() async {
     addOptionsFile('''
 ; #bang
 ''');
     setAnalysisRoot();
 
     await waitForTasksFinished();
 
-    expect(optionsFileErrors, hasLength(1));
-    expect(optionsFileErrors.first.severity, AnalysisErrorSeverity.ERROR);
-    expect(optionsFileErrors.first.type, AnalysisErrorType.COMPILE_TIME_ERROR);
+    if (!enableNewAnalysisDriver) {
+      // TODO(brianwilkerson) Implement options file analysis in the new driver.
+      expect(optionsFileErrors, hasLength(1));
+      expect(optionsFileErrors.first.severity, AnalysisErrorSeverity.ERROR);
+      expect(
+          optionsFileErrors.first.type, AnalysisErrorType.COMPILE_TIME_ERROR);
+    }
   }
 
   test_options_file_removed() async {
     setStrongMode(true);
 
     addTestFile(testSource);
     setAnalysisRoot();
 
     await waitForTasksFinished();
 
@@ skipping 100 matching lines @@
 @reflectiveTest
 class OldAnalysisOptionsFileNotificationTest_Driver
     extends OldAnalysisOptionsFileNotificationTest {
   @override
   void setUp() {
     enableNewAnalysisDriver = true;
     generateSummaryFiles = true;
     super.setUp();
   }
 }