Change HttpServerPropertiesManager::pref_task_runner_ to use TestMockTimeTaskRunner in unittests

Change HttpServerPropertiesManager::pref_task_runner_ to use TestMockTimeTaskRunner in unittests
so that we are able to verify tasks posted with delay in the future.

Now all the tests that used to ExpectPrefUpdate() will need to call
pref_task_runner_->FastForwardUntilNoTasksRemain() so that all the pref
tasks complete running. Note running the pref(net)_task_runner might result
in new tasks posted to net(pref)_task_runner.

BUG=670519
Committed: https://crrev.com/56fd0975bd8aded8e004fd4d52fc80e2fd51898c
Cr-Commit-Position: refs/heads/master@{#439374}

[Zhongyi Shi, 2016-12-14 22:44:36]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:45:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2016-12-14 23:42:45]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[Zhongyi Shi, 2016-12-14 23:42:46]

This cl changes the pref_task_runner in HttpServerPropertiesManager to use
TestMockTimeTaskRunner in unittests. 

Test only change. And I will be happy to walk you through the changes in the
unittests if needed.

[Ryan Hamilton, 2016-12-15 01:28:20]

Please mention HttpServerPropertiesManager in the CL description and CL title.

LGTM

[Zhongyi Shi, 2016-12-15 21:22:27]

Description was changed from

==========
Change pref_task_runner to use TestMockTimeTaskRunner in unittests
so that we are able to verify tasks posted with delay in the future.

Now all the tests that used to ExpectPrefUpdate() will need to call
pref_task_runner_->FastForwardUntilNoTasksRemain() so that all the pref
tasks complete running. Note running the pref(net)_task_runner might result
in new tasks posted to net(pref)_task_runner.

BUG=670519
==========

to

==========
Change HttpServerPropertiesManager::pref_task_runner_ to use
TestMockTimeTaskRunner in unittests
so that we are able to verify tasks posted with delay in the future.

Now all the tests that used to ExpectPrefUpdate() will need to call
pref_task_runner_->FastForwardUntilNoTasksRemain() so that all the pref
tasks complete running. Note running the pref(net)_task_runner might result
in new tasks posted to net(pref)_task_runner.

BUG=670519
==========

[Zhongyi Shi, 2016-12-17 00:42:09]

Patchset #3 (id:40001) has been deleted

[Zhongyi Shi, 2016-12-17 00:42:33]

Patchset #3 (id:60001) has been deleted

[Zhongyi Shi, 2016-12-18 16:36:31]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2016-12-18 16:36:32]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2577863002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-18 16:36:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 17:17:03]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1482078991677190,
"parent_rev": "2263406eafbd07982dd2c1b5ebd371d0440942c2", "commit_rev":
"3c94c74a74ec07d8a119e759816d5178f5d62701"}

[commit-bot: I haz the power, 2016-12-18 17:17:32]

Description was changed from

==========
Change HttpServerPropertiesManager::pref_task_runner_ to use
TestMockTimeTaskRunner in unittests
so that we are able to verify tasks posted with delay in the future.

Now all the tests that used to ExpectPrefUpdate() will need to call
pref_task_runner_->FastForwardUntilNoTasksRemain() so that all the pref
tasks complete running. Note running the pref(net)_task_runner might result
in new tasks posted to net(pref)_task_runner.

BUG=670519
==========

to

==========
Change HttpServerPropertiesManager::pref_task_runner_ to use
TestMockTimeTaskRunner in unittests
so that we are able to verify tasks posted with delay in the future.

Now all the tests that used to ExpectPrefUpdate() will need to call
pref_task_runner_->FastForwardUntilNoTasksRemain() so that all the pref
tasks complete running. Note running the pref(net)_task_runner might result
in new tasks posted to net(pref)_task_runner.

BUG=670519

Review-Url: https://codereview.chromium.org/2577863002
==========

[commit-bot: I haz the power, 2016-12-18 17:17:33]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-12-18 17:19:36]

Description was changed from

==========
Change HttpServerPropertiesManager::pref_task_runner_ to use
TestMockTimeTaskRunner in unittests
so that we are able to verify tasks posted with delay in the future.

Now all the tests that used to ExpectPrefUpdate() will need to call
pref_task_runner_->FastForwardUntilNoTasksRemain() so that all the pref
tasks complete running. Note running the pref(net)_task_runner might result
in new tasks posted to net(pref)_task_runner.

BUG=670519

Review-Url: https://codereview.chromium.org/2577863002
==========

to

==========
Change HttpServerPropertiesManager::pref_task_runner_ to use
TestMockTimeTaskRunner in unittests
so that we are able to verify tasks posted with delay in the future.

Now all the tests that used to ExpectPrefUpdate() will need to call
pref_task_runner_->FastForwardUntilNoTasksRemain() so that all the pref
tasks complete running. Note running the pref(net)_task_runner might result
in new tasks posted to net(pref)_task_runner.

BUG=670519

Committed: https://crrev.com/56fd0975bd8aded8e004fd4d52fc80e2fd51898c
Cr-Commit-Position: refs/heads/master@{#439374}
==========

[commit-bot: I haz the power, 2016-12-18 17:19:37]

Patchset 5 (id:??) landed as
https://crrev.com/56fd0975bd8aded8e004fd4d52fc80e2fd51898c
Cr-Commit-Position: refs/heads/master@{#439374}