[Refactor Xcode Objects] Decouple file references and indexing target.

[Refactor Xcode Objects] Decouple file references and indexing target.

Previously, whenever a file reference needs to be added for indexing, a default
target with the same name as the project is always assumed to be the one to
bound to.

This CL decouples file references from the default indexing target, and allows
file references to be bound to any of the native targets.

BUG=614818
Committed: https://crrev.com/898a56b7966c5686d276b6aa7f27ec922b37ab38
Cr-Commit-Position: refs/heads/master@{#439894}

[liaoyuke, 2016-12-14 20:20:26]

Description was changed from

==========
[Refactor Xcode objects]: decouple file references and targets.

BUG=
==========

to

==========
[Refactor Xcode Objects]: Decouple file references and indexing target.

Previously, whenever a file reference needs to be added for indexing, a default
target with the same name as the project is always assumed to be the one to
bound to.

This CL decouples file references from the default indexing target, and allows
file references to be bound to any of the native targets.

BUG=614818
==========

[liaoyuke, 2016-12-14 20:20:27]

liaoyuke@chromium.org changed reviewers:
+ justincohen@chromium.org, sdefresne@chromium.org

[liaoyuke, 2016-12-14 20:21:00]

Hi Sylvain, Justin,

Please take a look.

Thank you very much!

[liaoyuke, 2016-12-14 20:32:00]

Description was changed from

==========
[Refactor Xcode Objects]: Decouple file references and indexing target.

Previously, whenever a file reference needs to be added for indexing, a default
target with the same name as the project is always assumed to be the one to
bound to.

This CL decouples file references from the default indexing target, and allows
file references to be bound to any of the native targets.

BUG=614818
==========

to

==========
[Refactor Xcode Objects] Decouple file references and indexing target.

Previously, whenever a file reference needs to be added for indexing, a default
target with the same name as the project is always assumed to be the one to
bound to.

This CL decouples file references from the default indexing target, and allows
file references to be bound to any of the native targets.

BUG=614818
==========

[sdefresne, 2016-12-16 23:51:55]

LG but I have a question/comment.

https://codereview.chromium.org/2577753002/diff/20001/tools/gn/xcode_object.h
File tools/gn/xcode_object.h (right):

https://codereview.chromium.org/2577753002/diff/20001/tools/gn/xcode_object.h...
tools/gn/xcode_object.h:280: PBXNativeTarget* AddNativeTarget(const std::string&
name,
Why do you change the return value of this method? Is this for a followup CL? I
do not see any change to the caller of that method, so the returned value is
unused in that CL. Can you move the change to the followup CL instead and revert
in this one (or point me to where the value is used, I may have missed it).

[liaoyuke, 2016-12-19 08:03:35]

PTAL!

I know you are pretty busy with upstreaming. So, no rush, take your time to
review.

Thank you very much!

https://codereview.chromium.org/2577753002/diff/20001/tools/gn/xcode_object.h
File tools/gn/xcode_object.h (right):

https://codereview.chromium.org/2577753002/diff/20001/tools/gn/xcode_object.h...
tools/gn/xcode_object.h:280: PBXNativeTarget* AddNativeTarget(const std::string&
name,
On 2016/12/16 23:51:55, sdefresne wrote:
> Why do you change the return value of this method? Is this for a followup CL?
I
> do not see any change to the caller of that method, so the returned value is
> unused in that CL. Can you move the change to the followup CL instead and
revert
> in this one (or point me to where the value is used, I may have missed it).

Done. Yes, it is for a followup CL, I will move the change to later.

[sdefresne, 2016-12-19 08:09:53]

lgtm

[sdefresne, 2016-12-19 08:10:07]

You'll need dpranke or brettw approval for OWNERS.

[liaoyuke, 2016-12-19 08:18:20]

liaoyuke@chromium.org changed reviewers:
+ dpranke@chromium.org

[liaoyuke, 2016-12-19 08:22:58]

Thank you for reviewing!

Hello Dirk,

Could you please take a look for owner's approval?

Thank you very much!

[liaoyuke, 2016-12-20 17:24:52]

On 2016/12/19 08:22:58, liaoyuke wrote:
> Thank you for reviewing!
> 
> Hello Dirk,
> 
> Could you please take a look for owner's approval?
> 
> Thank you very much!

ping?

[Dirk Pranke, 2016-12-20 21:24:13]

lgtm, sorry for the delay.

[liaoyuke, 2016-12-20 21:59:00]

Thank you for reviewing :)

On Tue, Dec 20, 2016 at 1:24 PM <dpranke@chromium.org> wrote:

> lgtm, sorry for the delay.
>
> https://codereview.chromium.org/2577753002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[liaoyuke, 2016-12-20 22:13:50]

The CQ bit was checked by liaoyuke@chromium.org

[liaoyuke, 2016-12-20 22:13:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2577753002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-20 22:14:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 22:28:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482272030297350,
"parent_rev": "4889e79349ea9086f134dd2b0cf37355f1cac02b", "commit_rev":
"d5fdf6971384f684b704776c880b3c81a2704155"}

[commit-bot: I haz the power, 2016-12-20 22:28:33]

Description was changed from

==========
[Refactor Xcode Objects] Decouple file references and indexing target.

Previously, whenever a file reference needs to be added for indexing, a default
target with the same name as the project is always assumed to be the one to
bound to.

This CL decouples file references from the default indexing target, and allows
file references to be bound to any of the native targets.

BUG=614818
==========

to

==========
[Refactor Xcode Objects] Decouple file references and indexing target.

Previously, whenever a file reference needs to be added for indexing, a default
target with the same name as the project is always assumed to be the one to
bound to.

This CL decouples file references from the default indexing target, and allows
file references to be bound to any of the native targets.

BUG=614818

Review-Url: https://codereview.chromium.org/2577753002
==========

[commit-bot: I haz the power, 2016-12-20 22:28:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-20 22:30:19]

Description was changed from

==========
[Refactor Xcode Objects] Decouple file references and indexing target.

Previously, whenever a file reference needs to be added for indexing, a default
target with the same name as the project is always assumed to be the one to
bound to.

This CL decouples file references from the default indexing target, and allows
file references to be bound to any of the native targets.

BUG=614818

Review-Url: https://codereview.chromium.org/2577753002
==========

to

==========
[Refactor Xcode Objects] Decouple file references and indexing target.

Previously, whenever a file reference needs to be added for indexing, a default
target with the same name as the project is always assumed to be the one to
bound to.

This CL decouples file references from the default indexing target, and allows
file references to be bound to any of the native targets.

BUG=614818

Committed: https://crrev.com/898a56b7966c5686d276b6aa7f27ec922b37ab38
Cr-Commit-Position: refs/heads/master@{#439894}
==========

[commit-bot: I haz the power, 2016-12-20 22:30:19]

Patchset 4 (id:??) landed as
https://crrev.com/898a56b7966c5686d276b6aa7f27ec922b37ab38
Cr-Commit-Position: refs/heads/master@{#439894}