Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2577703002: Add credit card icons for the Payment Request UI. (Closed)

Created:
4 years ago by Justin Donnelly
Modified:
4 years ago
CC:
chromium-reviews, Moe
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add credit card icons for the Payment Request UI. BUG=602666 Committed: https://crrev.com/8b8bcb8cba2ce11d7e26e385ded91eff7a649126 Cr-Commit-Position: refs/heads/master@{#438809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M components/resources/autofill_scaled_resources.grdp View 1 chunk +10 lines, -13 lines 0 comments Download
A components/resources/default_100_percent/autofill/pr_amex.png View Binary file 0 comments Download
A components/resources/default_100_percent/autofill/pr_dinersclub.png View Binary file 0 comments Download
A components/resources/default_100_percent/autofill/pr_discover.png View Binary file 0 comments Download
A components/resources/default_100_percent/autofill/pr_generic.png View Binary file 0 comments Download
A components/resources/default_100_percent/autofill/pr_jcb.png View Binary file 0 comments Download
A components/resources/default_100_percent/autofill/pr_mc.png View Binary file 0 comments Download
A components/resources/default_100_percent/autofill/pr_mir.png View Binary file 0 comments Download
A components/resources/default_100_percent/autofill/pr_unionpay.png View Binary file 0 comments Download
A components/resources/default_100_percent/autofill/pr_visa.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_amex.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_dinersclub.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_discover.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_generic.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_jcb.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_mc.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_mir.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_unionpay.png View Binary file 0 comments Download
A components/resources/default_200_percent/autofill/pr_visa.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_amex.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_dinersclub.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_discover.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_generic.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_jcb.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_mc.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_mir.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_unionpay.png View Binary file 0 comments Download
A components/resources/default_300_percent/autofill/pr_visa.png View Binary file 0 comments Download

Messages

Total messages: 29 (15 generated)
Justin Donnelly
4 years ago (2016-12-14 18:35:26 UTC) #6
lpromero
lgtm
4 years ago (2016-12-14 21:11:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577703002/1
4 years ago (2016-12-14 21:12:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/326186)
4 years ago (2016-12-14 21:22:20 UTC) #11
Justin Donnelly
estade for OWNERS
4 years ago (2016-12-14 21:27:34 UTC) #13
Evan Stade
On 2016/12/14 21:27:34, Justin Donnelly wrote: > estade for OWNERS lgtm, but I would prefer ...
4 years ago (2016-12-14 23:59:07 UTC) #14
Justin Donnelly
On 2016/12/14 23:59:07, Evan Stade wrote: > On 2016/12/14 21:27:34, Justin Donnelly wrote: > > ...
4 years ago (2016-12-15 00:51:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577703002/1
4 years ago (2016-12-15 00:51:47 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/326427)
4 years ago (2016-12-15 01:03:22 UTC) #19
Justin Donnelly
sdefresne for even ownerier OWNERS review
4 years ago (2016-12-15 02:38:16 UTC) #21
sdefresne
lgtm
4 years ago (2016-12-15 12:03:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577703002/1
4 years ago (2016-12-15 12:03:58 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 12:08:31 UTC) #27
commit-bot: I haz the power
4 years ago (2016-12-15 12:11:02 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b8bcb8cba2ce11d7e26e385ded91eff7a649126
Cr-Commit-Position: refs/heads/master@{#438809}

Powered by Google App Engine
This is Rietveld 408576698