Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/326186)
On 2016/12/14 21:27:34, Justin Donnelly wrote:
> estade for OWNERS
lgtm, but I would prefer if the name was indicative of the difference between
these and the ones that already exist, something like visa_large.png or
visa_56.png, rather than a somewhat opaque abbreviation of the UI surface
they're used for.
Justin Donnelly
On 2016/12/14 23:59:07, Evan Stade wrote: > On 2016/12/14 21:27:34, Justin Donnelly wrote: > > ...
On 2016/12/14 23:59:07, Evan Stade wrote:
> On 2016/12/14 21:27:34, Justin Donnelly wrote:
> > estade for OWNERS
>
> lgtm, but I would prefer if the name was indicative of the difference between
> these and the ones that already exist, something like visa_large.png or
> visa_56.png, rather than a somewhat opaque abbreviation of the UI surface
> they're used for.
Yeah, I agree that makes more sense. But these are following a pattern
established by similar icons used on Android and I think it'd be worse to be
inconsistent.
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/326427)
Description was changed from
==========
Add credit card icons for the Payment Request UI.
BUG=602666
==========
to
==========
Add credit card icons for the Payment Request UI.
BUG=602666
Review-Url: https://codereview.chromium.org/2577703002
==========
Issue 2577703002: Add credit card icons for the Payment Request UI.
(Closed)
Created 4 years ago by Justin Donnelly
Modified 4 years ago
Reviewers: lpromero, Evan Stade, sdefresne
Base URL:
Comments: 0