Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2577653002: [regexp] Let RegExp.prototype.compile return this (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
Dan Ehrenberg, adamk, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Let RegExp.prototype.compile return this ES6 requires the compile method to return this: www.ecma-international.org/ecma-262/6.0/#sec-regexp.prototype.compile BUG=v8:5722, chromium:585775 Committed: https://crrev.com/f3b9d570cb79c7d1990d2ef11ce52ceb622b0e5a Cr-Commit-Position: refs/heads/master@{#41705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M src/builtins/builtins-regexp.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M test/mjsunit/regress/regress-585775.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
jgruber
This fixes one of the remaining ES6 incompatibilities: https://kangax.github.io/compat-table/es6/ I got in touch with snapdeal.com ...
4 years ago (2016-12-14 15:12:50 UTC) #6
Yang
On 2016/12/14 15:12:50, jgruber wrote: > This fixes one of the remaining ES6 incompatibilities: > ...
4 years ago (2016-12-14 15:14:59 UTC) #7
adamk
lgtm
4 years ago (2016-12-14 17:49:33 UTC) #8
Dan Ehrenberg
lgtm
4 years ago (2016-12-14 20:58:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577653002/1
4 years ago (2016-12-15 07:26:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 07:28:32 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-15 07:29:46 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3b9d570cb79c7d1990d2ef11ce52ceb622b0e5a
Cr-Commit-Position: refs/heads/master@{#41705}

Powered by Google App Engine
This is Rietveld 408576698