Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257763004: Removed parameter that is always true. (Closed)

Created:
6 years, 8 months ago by rune
Modified:
6 years, 8 months ago
CC:
blink-reviews, rwlbuis, chrishtr, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., ojan, Stephen Chennney, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removed parameter that is always true. The dirty parameter to InlineBox::markDirty is now always true. Remove it. Follow-up after landing https://codereview.chromium.org/254573006/ R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M Source/core/rendering/InlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rune
6 years, 8 months ago (2014-04-25 08:47:54 UTC) #1
ojan
lgtm
6 years, 8 months ago (2014-04-25 17:22:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/257763004/1
6 years, 8 months ago (2014-04-25 17:23:37 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 18:39:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-25 18:39:50 UTC) #5
rune
The CQ bit was checked by rune@opera.com
6 years, 8 months ago (2014-04-26 19:19:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/257763004/1
6 years, 8 months ago (2014-04-26 19:20:16 UTC) #7
eseidel
lgtm We used to have a ton of these. They're a hold over from khtml ...
6 years, 8 months ago (2014-04-26 20:19:25 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 20:46:02 UTC) #9
Message was sent while issue was closed. 
Change committed as 172704

Powered by Google App Engine
This is Rietveld 408576698