Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Issue 254573006: Avoid markDirty when removing out-of-flow line boxes. (Closed)

Created:
6 years, 8 months ago by rune
Modified:
6 years, 8 months ago
CC:
blink-reviews, chrishtr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., ojan, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid markDirty when removing out-of-flow line boxes. Previously, we did a markDirty(false) on the root line box in order to rectify the dirtyness caused by removing out-of-flow line boxes after layout. However, there were line boxes between root line box and the out-of-flow box that were left dirty. Instead we now avoid calling markDirty in the first place and remove the rectification code. Likewise, avoid markDirty when removing empty text renderers as mentioned in the removed comment. I tried to stop removing line boxes for the empty text renderers as the FIXME says, but the changed test expectations got too scary. Alternatively, we would have had to traverse the line box tree until we had cleaned all dirty bits. R=leviw@chromium.org,eseidel@chromium.org BUG=362671 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
A LayoutTests/fast/dynamic/static-to-relative-with-absolute-child.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/dynamic/static-to-relative-with-absolute-child-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineBox.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/rendering/InlineBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
6 years, 8 months ago (2014-04-24 16:49:14 UTC) #1
leviw_travelin_and_unemployed
This is much better, thank you. LGTM.
6 years, 8 months ago (2014-04-24 17:45:10 UTC) #2
rune
The CQ bit was checked by rune@opera.com
6 years, 8 months ago (2014-04-24 18:01:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/254573006/1
6 years, 8 months ago (2014-04-24 18:02:06 UTC) #4
rune
The CQ bit was unchecked by rune@opera.com
6 years, 8 months ago (2014-04-24 20:58:01 UTC) #5
rune
The CQ bit was checked by rune@opera.com
6 years, 8 months ago (2014-04-24 20:58:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/254573006/1
6 years, 8 months ago (2014-04-24 20:59:01 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:16:01 UTC) #8
Message was sent while issue was closed.
Change committed as 172550

Powered by Google App Engine
This is Rietveld 408576698