Issue 2577613003: [ImportantSites] Fixed important sites metrics & blacklisting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2577613003: [ImportantSites] Fixed important sites metrics & blacklisting (Closed)

Created:
4 years ago by dmurph

Modified:
4 years ago

Reviewers:
Theresa

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[ImportantSites] Fixed important sites metrics & blacklisting The important sites metrics & blacklist triggering wasn't notified when the user totally ignored the dialog and didn't deselect anything. R=twellington@chromium.org BUG=671815 Review-Url: https://codereview.chromium.org/2553053003 Cr-Commit-Position: refs/heads/master@{#437080} (cherry picked from commit 8cdeb8f50132914ed7a2817e982ed2e067e95ba9) Committed: https://chromium.googlesource.com/chromium/src/+/dad55b7ef4196472de177ee0baeb4a6df654fcbf

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/android/preferences/pref_service_bridge.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

dmurph

4 years ago (2016-12-14 16:47:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dad55b7ef4196472de177ee0baeb4a6df654fcbf.