Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2553053003: [ImportantSites] Fixed important sites metrics & blacklisting (Closed)

Created:
4 years ago by dmurph
Modified:
4 years ago
Reviewers:
Ted C, Theresa
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ImportantSites] Fixed important sites metrics & blacklisting The important sites metrics & blacklist triggering wasn't notified when the user totally ignored the dialog and didn't deselect anything. R=twellington@chromium.org BUG=671815 Committed: https://crrev.com/8cdeb8f50132914ed7a2817e982ed2e067e95ba9 Cr-Commit-Position: refs/heads/master@{#437080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
dmurph
Hello Theresa, Can you PTAL at this patch? This is a bug that I missed, ...
4 years ago (2016-12-06 22:43:34 UTC) #1
Theresa
lgtm
4 years ago (2016-12-06 22:45:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553053003/1
4 years ago (2016-12-06 22:48:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/319961)
4 years ago (2016-12-07 00:19:38 UTC) #6
dmurph
+tedchoc for approval
4 years ago (2016-12-07 00:56:20 UTC) #8
Ted C
lgtm
4 years ago (2016-12-07 18:50:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553053003/1
4 years ago (2016-12-07 22:01:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 22:14:55 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-07 22:17:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cdeb8f50132914ed7a2817e982ed2e067e95ba9
Cr-Commit-Position: refs/heads/master@{#437080}

Powered by Google App Engine
This is Rietveld 408576698