MacViews: Be robust against Views manipulating Layers during Widget::Close().

MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide().
A Hide() occurs synchronously in Widget::Close(), followed by tear down
that occurs asynchronously. Mac's BridgedNativeWidget (and
aura::Window::~Window()) suppress repaints during a close.
BridgedNativeWidget does this by clearing out the compositor. We
shouldn't try to subsequently recreate the compositor (there's a DCHECK
for that).

Manipulating Layers may call Widget::ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003
Committed: https://crrev.com/c8701123a47788c2dcd15f957ac02492d1138fa4
Cr-Commit-Position: refs/heads/master@{#438653}

[tapted, 2016-12-14 02:46:46]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:47:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-12-14 02:55:45]

Description was changed from

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().


BUG=673991
==========

to

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide()
that occurs synchronously in Widget::Close() before the asynchronous
tear down. NativeWidgetMac::Close() (and aura::Window::~Window())
suppress repaints during a close. NativeWidgetMac does this by clearing
out the compositor. We shouldn't try to subsequently recreate one.

NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView(). This is from before
ReorderChildViews() was implemented, but it's now no longer necessary.
It should always be a no-op: the RootView can't change.

BUG=673991
==========

[tapted, 2016-12-14 02:56:09]

Description was changed from

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide()
that occurs synchronously in Widget::Close() before the asynchronous
tear down. NativeWidgetMac::Close() (and aura::Window::~Window())
suppress repaints during a close. NativeWidgetMac does this by clearing
out the compositor. We shouldn't try to subsequently recreate one.

NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView(). This is from before
ReorderChildViews() was implemented, but it's now no longer necessary.
It should always be a no-op: the RootView can't change.

BUG=673991
==========

to

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide()
that occurs synchronously in Widget::Close() before the asynchronous
tear down. NativeWidgetMac::Close() (and aura::Window::~Window())
suppress repaints during a close. NativeWidgetMac does this by clearing
out the compositor. We shouldn't try to subsequently recreate the
compositor.

NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView(). This is from before
ReorderChildViews() was implemented, but it's now no longer necessary.
It should always be a no-op: the RootView can't change.

BUG=673991
==========

[tapted, 2016-12-14 02:57:09]

Description was changed from

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide()
that occurs synchronously in Widget::Close() before the asynchronous
tear down. NativeWidgetMac::Close() (and aura::Window::~Window())
suppress repaints during a close. NativeWidgetMac does this by clearing
out the compositor. We shouldn't try to subsequently recreate the
compositor.

NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView(). This is from before
ReorderChildViews() was implemented, but it's now no longer necessary.
It should always be a no-op: the RootView can't change.

BUG=673991
==========

to

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide()
that occurs synchronously in Widget::Close() before the asynchronous
tear down. NativeWidgetMac::Close() (and aura::Window::~Window())
suppress repaints during a close. NativeWidgetMac does this by clearing
out the compositor. We shouldn't try to subsequently recreate the
compositor.

Manipulating Layers may call ReorderNativeViews.
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's now
no longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991
==========

[commit-bot: I haz the power, 2016-12-14 03:27:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 03:27:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2016-12-14 05:02:49]

Description was changed from

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide()
that occurs synchronously in Widget::Close() before the asynchronous
tear down. NativeWidgetMac::Close() (and aura::Window::~Window())
suppress repaints during a close. NativeWidgetMac does this by clearing
out the compositor. We shouldn't try to subsequently recreate the
compositor.

Manipulating Layers may call ReorderNativeViews.
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's now
no longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991
==========

to

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide()
that occurs synchronously in Widget::Close() before the asynchronous
tear down. NativeWidgetMac::Close() (and aura::Window::~Window())
suppress repaints during a close. NativeWidgetMac does this by clearing
out the compositor. We shouldn't try to subsequently recreate the
compositor.

Manipulating Layers may call ReorderNativeViews.
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's now
no longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003
==========

[tapted, 2016-12-14 05:05:36]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 05:05:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 05:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 05:20:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tapted, 2016-12-14 06:18:08]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 06:18:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 07:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 07:18:21]

Dry run: This issue passed the CQ dry run.

[tapted, 2016-12-14 07:36:05]

Description was changed from

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide()
that occurs synchronously in Widget::Close() before the asynchronous
tear down. NativeWidgetMac::Close() (and aura::Window::~Window())
suppress repaints during a close. NativeWidgetMac does this by clearing
out the compositor. We shouldn't try to subsequently recreate the
compositor.

Manipulating Layers may call ReorderNativeViews.
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's now
no longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003
==========

to

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide().
The Hide() occurs synchronously in Widget::Close(), then tear down
happens asynchronously. NativeWidgetMac::Close() (and
aura::Window::~Window()) suppress repaints during a close.
NativeWidgetMac does this by clearing out the compositor. We shouldn't
try to subsequently recreate the compositor (there's a DCHECK for that).

Manipulating Layers may call ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003
==========

[tapted, 2016-12-14 07:36:05]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2016-12-14 07:43:25]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 07:43:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2016-12-14 07:43:48]

Description was changed from

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide().
The Hide() occurs synchronously in Widget::Close(), then tear down
happens asynchronously. NativeWidgetMac::Close() (and
aura::Window::~Window()) suppress repaints during a close.
NativeWidgetMac does this by clearing out the compositor. We shouldn't
try to subsequently recreate the compositor (there's a DCHECK for that).

Manipulating Layers may call ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003
==========

to

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide().
A Hide() occurs synchronously in Widget::Close(), followed by tear down
that occurs asynchronously. Mac's BridgedNativeWidget (and
aura::Window::~Window()) suppress repaints during a close.
BridgedNativeWidget does this by clearing out the compositor. We
shouldn't try to subsequently recreate the compositor (there's a DCHECK
for that).

Manipulating Layers may call Widget::ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003
==========

[tapted, 2016-12-14 07:45:27]

Hi sky, please take a look

[commit-bot: I haz the power, 2016-12-14 08:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 08:14:39]

Dry run: This issue passed the CQ dry run.

[sky, 2016-12-14 16:32:13]

LGTM

[tapted, 2016-12-14 22:26:49]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:27:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 22:34:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481754409896110,
"parent_rev": "a9bedfa27c029cbd024820db012fe612a5127c35", "commit_rev":
"0e0843dce6a5b85f123c7e21aeae606620f6f3a0"}

[commit-bot: I haz the power, 2016-12-14 22:35:02]

Description was changed from

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide().
A Hide() occurs synchronously in Widget::Close(), followed by tear down
that occurs asynchronously. Mac's BridgedNativeWidget (and
aura::Window::~Window()) suppress repaints during a close.
BridgedNativeWidget does this by clearing out the compositor. We
shouldn't try to subsequently recreate the compositor (there's a DCHECK
for that).

Manipulating Layers may call Widget::ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003
==========

to

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide().
A Hide() occurs synchronously in Widget::Close(), followed by tear down
that occurs asynchronously. Mac's BridgedNativeWidget (and
aura::Window::~Window()) suppress repaints during a close.
BridgedNativeWidget does this by clearing out the compositor. We
shouldn't try to subsequently recreate the compositor (there's a DCHECK
for that).

Manipulating Layers may call Widget::ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003

Review-Url: https://codereview.chromium.org/2577593002
==========

[commit-bot: I haz the power, 2016-12-14 22:35:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 22:36:49]

Description was changed from

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide().
A Hide() occurs synchronously in Widget::Close(), followed by tear down
that occurs asynchronously. Mac's BridgedNativeWidget (and
aura::Window::~Window()) suppress repaints during a close.
BridgedNativeWidget does this by clearing out the compositor. We
shouldn't try to subsequently recreate the compositor (there's a DCHECK
for that).

Manipulating Layers may call Widget::ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003

Review-Url: https://codereview.chromium.org/2577593002
==========

to

==========
MacViews: Be robust against Views manipulating Layers during Widget::Close().

An InkDropHostView may manipulate layers in response the Widget::Hide().
A Hide() occurs synchronously in Widget::Close(), followed by tear down
that occurs asynchronously. Mac's BridgedNativeWidget (and
aura::Window::~Window()) suppress repaints during a close.
BridgedNativeWidget does this by clearing out the compositor. We
shouldn't try to subsequently recreate the compositor (there's a DCHECK
for that).

Manipulating Layers may call Widget::ReorderNativeViews. And
NativeWidgetMac::ReorderNativeViews() currently calls
BridgedNativeWidget::SetRootView() (which updates the compositor). It's
done this since before ReorderChildViews() was implemented, but it's no
longer necessary. It should always be a no-op: the RootView can't
change.

BUG=673991, 674003

Committed: https://crrev.com/c8701123a47788c2dcd15f957ac02492d1138fa4
Cr-Commit-Position: refs/heads/master@{#438653}
==========

[commit-bot: I haz the power, 2016-12-14 22:36:50]

Patchset 4 (id:??) landed as
https://crrev.com/c8701123a47788c2dcd15f957ac02492d1138fa4
Cr-Commit-Position: refs/heads/master@{#438653}