Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2577583003: Retry installing with UI if silent installation is unsuccessful. (Closed)

Created:
4 years ago by pastarmovj
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retry installing with UI if silent installation is unsuccessful. Until the driver is not signed with the proper Microsoft cert from the WHQL program or Google's cert is added as a 'Tristed Publisher' installation can not be performed unless the user confirms that they trust the driver issuer. BUG=629512 TEST=manual (see bug#127) Committed: https://crrev.com/1a26ccd2555e131a049bcdf80655b7bba10fecf0 Cr-Commit-Position: refs/heads/master@{#438487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M cloud_print/virtual_driver/win/install/setup.cc View 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pastarmovj
Please review this rather trivial CL. Thanks! Julian
4 years ago (2016-12-14 11:16:28 UTC) #2
Andrew T Wilson (Slow)
lgtm
4 years ago (2016-12-14 11:20:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577583003/1
4 years ago (2016-12-14 11:23:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 12:17:14 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-14 12:19:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a26ccd2555e131a049bcdf80655b7bba10fecf0
Cr-Commit-Position: refs/heads/master@{#438487}

Powered by Google App Engine
This is Rietveld 408576698