Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2577533002: Revert of Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. (Closed)

Created:
4 years ago by Will Harris
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. (patchset #1 id:1 of https://codereview.chromium.org/2566733003/ ) Reason for revert: These issues have been resolved in the latest update from Trusteer. Original issue's description: > Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. > > BUG=671194 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > TEST=manual, install Trusteer Rapport, verify dialog appears. > > Committed: https://crrev.com/07a5425d95dc96b3d0a3bd8acad943cf0f4cd2fb > Cr-Commit-Position: refs/heads/master@{#437729} TBR=chrisha@chromium.org,jschuh@chromium.org,finnur@chromium.org,pmonette@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671194 Committed: https://crrev.com/b17b3a185ede96b5654f5ece8d19ee4f070d96ce Cr-Commit-Position: refs/heads/master@{#438293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/browser/win/enumerate_modules_model.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/win/enumerate_modules_model.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Will Harris
Created Revert of Annotate Trusteer Rapport < 3.6 as incompatible with Chrome.
4 years ago (2016-12-13 20:35:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577533002/1
4 years ago (2016-12-13 20:35:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 21:48:22 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b17b3a185ede96b5654f5ece8d19ee4f070d96ce Cr-Commit-Position: refs/heads/master@{#438293}
4 years ago (2016-12-13 21:52:15 UTC) #8
chrisha
4 years ago (2016-12-13 21:54:56 UTC) #9
Message was sent while issue was closed.
lgtm!

Powered by Google App Engine
This is Rietveld 408576698