Misc HostResolverImpl refactors.

Misc HostResolverImpl refactors.

 * Don't cache ERR_ICANN_NAME_COLLISION under task-based resolver (to
   match proc-based resolver)

 * Save an empty address list in cache for ERR_ICANN_NAME_COLLISION
   entries (rather than the address list originally resolved).

BUG=670093
Committed: https://crrev.com/0cd87b66f47aa7f08c09eab08f9c6303dd107766
Cr-Commit-Position: refs/heads/master@{#438575}

[eroman, 2016-12-14 00:16:51]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 00:17:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-12-14 00:19:52]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[eroman, 2016-12-14 00:19:53]

Follow-up from https://codereview.chromium.org/2567623003/

I missed some subtleties around the caching TTL in the earlier CL, which I have
covered in tests here.

https://codereview.chromium.org/2577503003/diff/1/net/dns/host_resolver_impl.cc
File net/dns/host_resolver_impl.cc (right):

https://codereview.chromium.org/2577503003/diff/1/net/dns/host_resolver_impl....
net/dns/host_resolver_impl.cc:1731:
CompleteRequestsWithError(ERR_ICANN_NAME_COLLISION);
This has a subtly different behavior for caching (see unit-test).

[commit-bot: I haz the power, 2016-12-14 01:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:47:18]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-12-14 16:24:07]

LGTM, thanks!

[eroman, 2016-12-14 17:25:21]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:25:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:13:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481736321562150, "parent_rev":
"34c8e6107af9c42f1ce80c9b8ffc2ea243797008", "commit_rev":
"e9ba4406f1093545ded9964d37433df2f5791bdc"}

[commit-bot: I haz the power, 2016-12-14 19:14:17]

Description was changed from

==========
Misc HostResolverImpl refactors.

 * Don't cache ERR_ICANN_NAME_COLLISION under task-based resolver (to
   match proc-based resolver)

 * Save an empty address list in cache for ERR_ICANN_NAME_COLLISION
   entries (rather than the address list originally resolved).

BUG=670093
==========

to

==========
Misc HostResolverImpl refactors.

 * Don't cache ERR_ICANN_NAME_COLLISION under task-based resolver (to
   match proc-based resolver)

 * Save an empty address list in cache for ERR_ICANN_NAME_COLLISION
   entries (rather than the address list originally resolved).

BUG=670093

Review-Url: https://codereview.chromium.org/2577503003
==========

[commit-bot: I haz the power, 2016-12-14 19:14:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 19:16:56]

Description was changed from

==========
Misc HostResolverImpl refactors.

 * Don't cache ERR_ICANN_NAME_COLLISION under task-based resolver (to
   match proc-based resolver)

 * Save an empty address list in cache for ERR_ICANN_NAME_COLLISION
   entries (rather than the address list originally resolved).

BUG=670093

Review-Url: https://codereview.chromium.org/2577503003
==========

to

==========
Misc HostResolverImpl refactors.

 * Don't cache ERR_ICANN_NAME_COLLISION under task-based resolver (to
   match proc-based resolver)

 * Save an empty address list in cache for ERR_ICANN_NAME_COLLISION
   entries (rather than the address list originally resolved).

BUG=670093

Committed: https://crrev.com/0cd87b66f47aa7f08c09eab08f9c6303dd107766
Cr-Commit-Position: refs/heads/master@{#438575}
==========

[commit-bot: I haz the power, 2016-12-14 19:16:57]

Patchset 1 (id:??) landed as
https://crrev.com/0cd87b66f47aa7f08c09eab08f9c6303dd107766
Cr-Commit-Position: refs/heads/master@{#438575}