Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2577493002: Clean up chrome/test/BUILD.gn for Chrome OS and ash (Closed)

Created:
4 years ago by James Cook
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up chrome/test/BUILD.gn for Chrome OS and ash Ash only ships on Chrome OS, so simplify the BUILD.gn file by removing cases that assume use_ash but !is_chromeos. BUG=666776 TEST=bots Committed: https://crrev.com/3a81b59b30f523ae825654f7ddc44a95ecd77f0c Cr-Commit-Position: refs/heads/master@{#438426}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -32 lines) Patch
M chrome/test/BUILD.gn View 1 5 chunks +7 lines, -32 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
James Cook
sky, please take a look.
4 years ago (2016-12-13 20:15:40 UTC) #6
sky
LGTM https://codereview.chromium.org/2577493002/diff/1/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/2577493002/diff/1/chrome/test/BUILD.gn#newcode4134 chrome/test/BUILD.gn:4134: # Ash uses window_sizer_ash_unittest.cc Ash->Chromeos?
4 years ago (2016-12-13 21:08:23 UTC) #7
James Cook
https://codereview.chromium.org/2577493002/diff/1/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/2577493002/diff/1/chrome/test/BUILD.gn#newcode4134 chrome/test/BUILD.gn:4134: # Ash uses window_sizer_ash_unittest.cc On 2016/12/13 21:08:23, sky wrote: ...
4 years ago (2016-12-14 02:53:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577493002/20001
4 years ago (2016-12-14 02:54:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 04:15:46 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-14 04:20:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a81b59b30f523ae825654f7ddc44a95ecd77f0c
Cr-Commit-Position: refs/heads/master@{#438426}

Powered by Google App Engine
This is Rietveld 408576698