Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years ago by bradnelson Modified:
4 years ago Reviewers:
titzer, bradn, Yang CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm][asm.js] Adding timing info message about asm.js
Adding timing info going to the console about asm.js
Rename ConvertAsmToWasm -> CompileAsmViaWasm, to be more precise.
Add enum for wasm data elements.
BUG=v8:4203
R=titzer@chromium.org,yangguo@chromium.org
Committed: https://crrev.com/21255208e279f9bfab3b1c72d778877490efcec5
Cr-Commit-Position: refs/heads/master@{#41695}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : fix #Patch Set 4 : fix #
Created: 4 years ago
Messages
Total messages: 27 (20 generated)
bradnelson@google.com changed reviewers: + bradnelson@google.com
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/14 12:10:15, bradn wrote: lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bradnelson@google.com
The CQ bit was checked by bradnelson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2577453003/#ps40001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by bradnelson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2577453003/#ps60001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481723111824530,
"parent_rev": "76a5887f114297fc45ebf08c16088f17f14daa1c", "commit_rev":
"2991e97b72829b35aec785d31b905898bfd646ae"}
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Adding timing info message about asm.js Adding timing info going to the console about asm.js Rename ConvertAsmToWasm -> CompileAsmViaWasm, to be more precise. Add enum for wasm data elements. BUG=v8:4203 R=titzer@chromium.org,yangguo@chromium.org ========== to ========== [wasm][asm.js] Adding timing info message about asm.js Adding timing info going to the console about asm.js Rename ConvertAsmToWasm -> CompileAsmViaWasm, to be more precise. Add enum for wasm data elements. BUG=v8:4203 R=titzer@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2577453003 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Adding timing info message about asm.js Adding timing info going to the console about asm.js Rename ConvertAsmToWasm -> CompileAsmViaWasm, to be more precise. Add enum for wasm data elements. BUG=v8:4203 R=titzer@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2577453003 ========== to ========== [wasm][asm.js] Adding timing info message about asm.js Adding timing info going to the console about asm.js Rename ConvertAsmToWasm -> CompileAsmViaWasm, to be more precise. Add enum for wasm data elements. BUG=v8:4203 R=titzer@chromium.org,yangguo@chromium.org Committed: https://crrev.com/21255208e279f9bfab3b1c72d778877490efcec5 Cr-Commit-Position: refs/heads/master@{#41695} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/21255208e279f9bfab3b1c72d778877490efcec5 Cr-Commit-Position: refs/heads/master@{#41695} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
