Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2577453003: [wasm][asm.js] Adding timing info message about asm.js (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer, bradn, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Adding timing info message about asm.js Adding timing info going to the console about asm.js Rename ConvertAsmToWasm -> CompileAsmViaWasm, to be more precise. Add enum for wasm data elements. BUG=v8:4203 R=titzer@chromium.org,yangguo@chromium.org Committed: https://crrev.com/21255208e279f9bfab3b1c72d778877490efcec5 Cr-Commit-Position: refs/heads/master@{#41695}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -11 lines) Patch
M src/asmjs/asm-js.h View 1 chunk +1 line, -1 line 0 comments Download
M src/asmjs/asm-js.cc View 1 2 3 6 chunks +68 lines, -8 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 27 (20 generated)
bradn
4 years ago (2016-12-14 12:10:15 UTC) #2
titzer
On 2016/12/14 12:10:15, bradn wrote: lgtm
4 years ago (2016-12-14 12:14:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577453003/40001
4 years ago (2016-12-14 13:35:20 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/9644)
4 years ago (2016-12-14 13:41:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577453003/60001
4 years ago (2016-12-14 13:45:20 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-14 14:09:31 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-14 14:10:34 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/21255208e279f9bfab3b1c72d778877490efcec5
Cr-Commit-Position: refs/heads/master@{#41695}

Powered by Google App Engine
This is Rietveld 408576698