Description was changed from
==========
Revert of Cleanup DataReductionProxy (DRP) Brotli code (patchset #3 id:140001 of
https://codereview.chromium.org/2571993002/ )
Reason for revert:
Reverting because it's hitting a DCHECK on top of tree (android). It's going to
make it hard for people to work.
Filed a bug at https://bugs.chromium.org/p/chromium/issues/detail?id=674918
Original issue's description:
> Cleanup DataReductionProxy (DRP) Brotli code
>
> Add thread checkers to request options class.
>
> Force the generation of the chrome-proxy header, and use it later when
> generating the MockWrite for the sockets in tests.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
>
> BUG=634061
>
> Committed: https://crrev.com/1d20801e2b126cfec1d66cb78c05082d0f90b3ba
> Cr-Commit-Position: refs/heads/master@{#438978}
TBR=ryansturm@chromium.org,tbansal@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634061
==========
to
==========
Revert of Cleanup DataReductionProxy (DRP) Brotli code (patchset #3 id:140001 of
https://codereview.chromium.org/2571993002/ )
Reason for revert:
Reverting because it's hitting a DCHECK on top of tree (android). It's going to
make it hard for people to work.
Filed a bug at https://bugs.chromium.org/p/chromium/issues/detail?id=674918
Original issue's description:
> Cleanup DataReductionProxy (DRP) Brotli code
>
> Add thread checkers to request options class.
>
> Force the generation of the chrome-proxy header, and use it later when
> generating the MockWrite for the sockets in tests.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
>
> BUG=634061
>
> Committed: https://crrev.com/1d20801e2b126cfec1d66cb78c05082d0f90b3ba
> Cr-Commit-Position: refs/heads/master@{#438978}
TBR=ryansturm@chromium.org,tbansal@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634061
Review-Url: https://codereview.chromium.org/2577413002
==========
Description was changed from
==========
Revert of Cleanup DataReductionProxy (DRP) Brotli code (patchset #3 id:140001 of
https://codereview.chromium.org/2571993002/ )
Reason for revert:
Reverting because it's hitting a DCHECK on top of tree (android). It's going to
make it hard for people to work.
Filed a bug at https://bugs.chromium.org/p/chromium/issues/detail?id=674918
Original issue's description:
> Cleanup DataReductionProxy (DRP) Brotli code
>
> Add thread checkers to request options class.
>
> Force the generation of the chrome-proxy header, and use it later when
> generating the MockWrite for the sockets in tests.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
>
> BUG=634061
>
> Committed: https://crrev.com/1d20801e2b126cfec1d66cb78c05082d0f90b3ba
> Cr-Commit-Position: refs/heads/master@{#438978}
TBR=ryansturm@chromium.org,tbansal@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634061
Review-Url: https://codereview.chromium.org/2577413002
==========
to
==========
Revert of Cleanup DataReductionProxy (DRP) Brotli code (patchset #3 id:140001 of
https://codereview.chromium.org/2571993002/ )
Reason for revert:
Reverting because it's hitting a DCHECK on top of tree (android). It's going to
make it hard for people to work.
Filed a bug at https://bugs.chromium.org/p/chromium/issues/detail?id=674918
Original issue's description:
> Cleanup DataReductionProxy (DRP) Brotli code
>
> Add thread checkers to request options class.
>
> Force the generation of the chrome-proxy header, and use it later when
> generating the MockWrite for the sockets in tests.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
>
> BUG=634061
>
> Committed: https://crrev.com/1d20801e2b126cfec1d66cb78c05082d0f90b3ba
> Cr-Commit-Position: refs/heads/master@{#438978}
TBR=ryansturm@chromium.org,tbansal@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634061
Committed: https://crrev.com/b7e7022d9679740ace361f373f754a506f9e72e1
Cr-Commit-Position: refs/heads/master@{#439103}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b7e7022d9679740ace361f373f754a506f9e72e1 Cr-Commit-Position: refs/heads/master@{#439103}
Issue 2577413002: Revert of Cleanup DataReductionProxy (DRP) Brotli code
(Closed)
Created 4 years ago by Mathieu
Modified 4 years ago
Reviewers: RyanSturm, tbansal1
Base URL:
Comments: 0