Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2577413002: Revert of Cleanup DataReductionProxy (DRP) Brotli code (Closed)

Created:
4 years ago by Mathieu
Modified:
4 years ago
Reviewers:
RyanSturm, tbansal1
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleanup DataReductionProxy (DRP) Brotli code (patchset #3 id:140001 of https://codereview.chromium.org/2571993002/ ) Reason for revert: Reverting because it's hitting a DCHECK on top of tree (android). It's going to make it hard for people to work. Filed a bug at https://bugs.chromium.org/p/chromium/issues/detail?id=674918 Original issue's description: > Cleanup DataReductionProxy (DRP) Brotli code > > Add thread checkers to request options class. > > Force the generation of the chrome-proxy header, and use it later when > generating the MockWrite for the sockets in tests. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > BUG=634061 > > Committed: https://crrev.com/1d20801e2b126cfec1d66cb78c05082d0f90b3ba > Cr-Commit-Position: refs/heads/master@{#438978} TBR=ryansturm@chromium.org,tbansal@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634061 Committed: https://crrev.com/b7e7022d9679740ace361f373f754a506f9e72e1 Cr-Commit-Position: refs/heads/master@{#439103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -95 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 15 chunks +42 lines, -54 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h View 5 chunks +5 lines, -11 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Mathieu
Created Revert of Cleanup DataReductionProxy (DRP) Brotli code
4 years ago (2016-12-16 14:53:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577413002/1
4 years ago (2016-12-16 14:53:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 14:54:49 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-16 14:57:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7e7022d9679740ace361f373f754a506f9e72e1
Cr-Commit-Position: refs/heads/master@{#439103}

Powered by Google App Engine
This is Rietveld 408576698