Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2577353002:
memory coordinator: Sends notifications to V8 on THROTTLED state (Closed)
Descriptionmemory coordinator: Sends notifications to V8 on THROTTLED state
When a renderer enters THROTTLED state, we should send a notifications
to V8 so that V8 is aware of memory pressure.
BUG=674815
Committed: https://crrev.com/a55dae12321bc554beee9fbeb736ca62d78a556e
Cr-Commit-Position: refs/heads/master@{#439410}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rebase #Patch Set 3 : rebase #Messages
Total messages: 26 (17 generated)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bashi@chromium.org changed reviewers: + haraken@chromium.org, jam@chromium.org
PTAL As I wrote in the description of the bug entry, we don't have enough information to decide what we should do on THROTTLED state. I want to do some try-and-iterate here. Please let me know if this doesn't sound a good idea.
LGTM https://codereview.chromium.org/2577353002/diff/1/content/renderer/render_thr... File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/2577353002/diff/1/content/renderer/render_thr... content/renderer/render_thread_impl.cc:2305: OnTrimMemoryImmediately(); Note that if you use OnTrimMemoryImmediatelydirectly, it sends a critical signal even if the renderer is foregrounded. OnSyncMemoryPressure translates the critical signal to a moderate signal if the renderer is foregrounded. It's up to you though -- we'll need some experiments to figure out a suitable strategy.
https://codereview.chromium.org/2577353002/diff/1/content/renderer/render_thr... File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/2577353002/diff/1/content/renderer/render_thr... content/renderer/render_thread_impl.cc:2305: OnTrimMemoryImmediately(); On 2016/12/16 06:27:13, haraken wrote: > > Note that if you use OnTrimMemoryImmediatelydirectly, it sends a critical signal > even if the renderer is foregrounded. OnSyncMemoryPressure translates the > critical signal to a moderate signal if the renderer is foregrounded. > > It's up to you though -- we'll need some experiments to figure out a suitable > strategy. > > Yeah, I understand the risk. As MC doesn't send SUSPENDED notification to foreground tabs, THROTTLED state is the only state on which we can send critical notification. This fact might indicate that we need some design changes in MC, but I'd like to start here.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rubberstamp lgtm
The CQ bit was checked by bashi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, jam@chromium.org Link to the patchset: https://codereview.chromium.org/2577353002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bashi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, jam@chromium.org Link to the patchset: https://codereview.chromium.org/2577353002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482121810857630,
"parent_rev": "f52afd93fa99e1f11f5a6dd1a1b12d93a47babf9", "commit_rev":
"60721fcf2b81457213e2d6279c43a3d8605df640"}
Message was sent while issue was closed.
Description was changed from ========== memory coordinator: Sends notifications to V8 on THROTTLED state When a renderer enters THROTTLED state, we should send a notifications to V8 so that V8 is aware of memory pressure. BUG=674815 ========== to ========== memory coordinator: Sends notifications to V8 on THROTTLED state When a renderer enters THROTTLED state, we should send a notifications to V8 so that V8 is aware of memory pressure. BUG=674815 Review-Url: https://codereview.chromium.org/2577353002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== memory coordinator: Sends notifications to V8 on THROTTLED state When a renderer enters THROTTLED state, we should send a notifications to V8 so that V8 is aware of memory pressure. BUG=674815 Review-Url: https://codereview.chromium.org/2577353002 ========== to ========== memory coordinator: Sends notifications to V8 on THROTTLED state When a renderer enters THROTTLED state, we should send a notifications to V8 so that V8 is aware of memory pressure. BUG=674815 Committed: https://crrev.com/a55dae12321bc554beee9fbeb736ca62d78a556e Cr-Commit-Position: refs/heads/master@{#439410} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a55dae12321bc554beee9fbeb736ca62d78a556e Cr-Commit-Position: refs/heads/master@{#439410} |
