Convert ClangToTiOS on chromium.fyi to do a simulator/debug build and run all tests

Convert ClangToTiOS on chromium.fyi to do a simulator/debug build and run all tests

BUG=673621
Committed: https://crrev.com/dfa33876e22dbdcb2ac21b4ba75dd626dd1bc046
Cr-Commit-Position: refs/heads/master@{#439019}

[smut, 2016-12-16 01:48:26]

smut@google.com changed reviewers:
+ justincohen@chromium.org

[smut, 2016-12-16 01:48:26]

This gives us simulator/debug+tests upstream and device/release+tests
downstream. When there's a solution for devices upstream they can both be
upstream.

[justincohen, 2016-12-16 01:59:24]

lgtm

[smut, 2016-12-16 02:06:27]

The CQ bit was checked by smut@google.com

[commit-bot: I haz the power, 2016-12-16 02:07:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 04:15:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481853987989800, "parent_rev":
"220ea3f460e2f31eda99fcf245056813be0cc53c", "commit_rev":
"9c2e6af4837b7f639f581e081708a8fce38bdc50"}

[commit-bot: I haz the power, 2016-12-16 04:15:54]

Description was changed from

==========
Convert ClangToTiOS on chromium.fyi to do a simulator/debug build and run all
tests

BUG=673621
==========

to

==========
Convert ClangToTiOS on chromium.fyi to do a simulator/debug build and run all
tests

BUG=673621

Review-Url: https://codereview.chromium.org/2577323002
==========

[commit-bot: I haz the power, 2016-12-16 04:15:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 04:19:36]

Description was changed from

==========
Convert ClangToTiOS on chromium.fyi to do a simulator/debug build and run all
tests

BUG=673621

Review-Url: https://codereview.chromium.org/2577323002
==========

to

==========
Convert ClangToTiOS on chromium.fyi to do a simulator/debug build and run all
tests

BUG=673621

Committed: https://crrev.com/dfa33876e22dbdcb2ac21b4ba75dd626dd1bc046
Cr-Commit-Position: refs/heads/master@{#439019}
==========

[commit-bot: I haz the power, 2016-12-16 04:19:37]

Patchset 1 (id:??) landed as
https://crrev.com/dfa33876e22dbdcb2ac21b4ba75dd626dd1bc046
Cr-Commit-Position: refs/heads/master@{#439019}

[Nico, 2016-12-16 04:23:08]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-12-16 04:23:09]

I explicitly asked you not to do that on the bug. Please revert this, and please
let us review tot waterfall changes.

[justincohen, 2016-12-16 04:27:11]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2580733007/ by justincohen@chromium.org.

The reason for reverting is: per thakis@.

[smut, 2016-12-16 22:32:34]

On 2016/12/16 04:23:09, Nico (out Thu Dec 15) wrote:
> I explicitly asked you not to do that on the bug. Please revert this, and
please
> let us review tot waterfall changes.

I had already committed it by the time you said that (or at least I had CQed it
and I thought it was committed).

[Nico, 2016-12-16 22:35:22]

No worries, all good now :-)

On Fri, Dec 16, 2016 at 5:32 PM, <smut@google.com> wrote:

> On 2016/12/16 04:23:09, Nico (out Thu Dec 15) wrote:
> > I explicitly asked you not to do that on the bug. Please revert this, and
> please
> > let us review tot waterfall changes.
>
> I had already committed it by the time you said that (or at least I had
> CQed it
> and I thought it was committed).
>
> https://codereview.chromium.org/2577323002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.