Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2577233002: Revert of [DevTools] Migrate ServiceWorker domain to new generator. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
caseq
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2573993003/ ) Reason for revert: Crashes. BUG=674474 Original issue's description: > [DevTools] Migrate ServiceWorker domain to new generator. > > BUG=664683 > TBR=pfeldman > > Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f > Cr-Commit-Position: refs/heads/master@{#438676} TBR=caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664683 Committed: https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5 Cr-Commit-Position: refs/heads/master@{#438942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -131 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.h View 4 chunks +31 lines, -18 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 8 chunks +111 lines, -95 lines 0 comments Download
M content/browser/devtools/protocol_config.json View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 6 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dgozman
Created Revert of [DevTools] Migrate ServiceWorker domain to new generator.
4 years ago (2016-12-15 22:32:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577233002/1
4 years ago (2016-12-15 22:52:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 22:53:36 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5 Cr-Commit-Position: refs/heads/master@{#438942}
4 years ago (2016-12-15 22:55:39 UTC) #9
dgozman
4 years ago (2016-12-16 04:06:28 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2580833004/ by dgozman@chromium.org.

The reason for reverting is: Fixed crash reason in
https://codereview.chromium.org/2579923002/.

Powered by Google App Engine
This is Rietveld 408576698