Better tests for password protected documents.

Better tests for password protected documents.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.

Review-Url: https://codereview.chromium.org/2577223002
Committed: https://pdfium.googlesource.com/pdfium/+/ad3cd2aeff15bd31aa38544063075d910ac63823

[Tom Sepez, 2016-12-15 22:01:42]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:01:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-15 22:02:50]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-12-15 22:02:50]

Dan, for review.

[commit-bot: I haz the power, 2016-12-15 22:13:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 22:13:54]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-15 23:35:36]

Description was changed from

==========
Add cmd line option to pdfium_test for password protected documents.

Although morally reprehensible to ask for this on the command line,
it aids with testing when the password isn't really a secret.  Hopefully
the argument name and usage summary will be sufficient.
==========

to

==========
Better tests for password protected documents.

- Add cmd line option to pdfium_test for password protected documents.
Although morally reprehensible to ask for this on the command line,
it aids with testing when the password isn't really a secret.
Hopefully the argument name and usage summary will be sufficient.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.
==========

[Tom Sepez, 2016-12-15 23:35:53]

Dan, more stuff, might as well lump this together.

[Tom Sepez, 2016-12-15 23:36:00]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 23:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-15 23:37:26]

Description was changed from

==========
Better tests for password protected documents.

- Add cmd line option to pdfium_test for password protected documents.
Although morally reprehensible to ask for this on the command line,
it aids with testing when the password isn't really a secret.
Hopefully the argument name and usage summary will be sufficient.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.
==========

to

==========
Better tests for password protected documents.

- Add cmd line option to pdfium_test for password protected documents.
    Although morally reprehensible to ask for this on the command line,
    it aids with testing when the password isn't really a secret.
    Hopefully the argument name and usage summary will be sufficient.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.
==========

[Tom Sepez, 2016-12-15 23:38:03]

Description was changed from

==========
Better tests for password protected documents.

- Add cmd line option to pdfium_test for password protected documents.
    Although morally reprehensible to ask for this on the command line,
    it aids with testing when the password isn't really a secret.
    Hopefully the argument name and usage summary will be sufficient.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.
==========

to

==========
Better tests for password protected documents.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.
- Add cmd line option to pdfium_test for password protected documents.

Although morally reprehensible to ask for this on the command line,
it aids with testing when the password isn't really a secret.
Hopefully the argument name and usage summary will be sufficient.
==========

[Tom Sepez, 2016-12-15 23:48:49]

https://codereview.chromium.org/2577223002/diff/40001/core/fdrm/crypto/fx_cry...
File core/fdrm/crypto/fx_crypt.h (right):

https://codereview.chromium.org/2577223002/diff/40001/core/fdrm/crypto/fx_cry...
core/fdrm/crypto/fx_crypt.h:16: typedef struct {
nit: just to make this compile under C.

[commit-bot: I haz the power, 2016-12-15 23:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 23:49:19]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-16 03:44:58]

lgtm

[Tom Sepez, 2016-12-16 19:05:03]

Description was changed from

==========
Better tests for password protected documents.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.
- Add cmd line option to pdfium_test for password protected documents.

Although morally reprehensible to ask for this on the command line,
it aids with testing when the password isn't really a secret.
Hopefully the argument name and usage summary will be sufficient.
==========

to

==========
Better tests for password protected documents.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.
==========

[Tom Sepez, 2016-12-16 19:05:31]

Removed password option from pdfium_test, we can already do
this via embedder tests, no need to complicate it.

[Tom Sepez, 2016-12-16 19:05:36]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-12-16 19:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2577223002/#ps80001
(title: "revert pdfium_test")

[commit-bot: I haz the power, 2016-12-16 19:05:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 19:16:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481915136116420,
"parent_rev": "47fb8c06acd0ff9ea50c8c2d7f67510ea5c28577", "commit_rev":
"ad3cd2aeff15bd31aa38544063075d910ac63823"}

[commit-bot: I haz the power, 2016-12-16 19:16:27]

Description was changed from

==========
Better tests for password protected documents.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.
==========

to

==========
Better tests for password protected documents.

- Add unit tests for sha256 implementation.
- Remove void* types from API in favor of correct actual types.

Review-Url: https://codereview.chromium.org/2577223002
Committed:
https://pdfium.googlesource.com/pdfium/+/ad3cd2aeff15bd31aa38544063075d910ac6...
==========

[commit-bot: I haz the power, 2016-12-16 19:16:27]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/ad3cd2aeff15bd31aa38544063075d910ac6...