Add UMA for the number of devices in the chooser when a device is paired

Add UMA for the number of devices in the chooser when a device is paired

In the case of not accepting all devices in the options that are given
to WebBluetooth requestDevice(), knowing the number of devices that are
in the chooser is helpful for researching some methods to distinguish
devices with the same name. This CL adds UMA for the number of devices
that are in the chooser when a device is paired.

BUG=674195
Committed: https://crrev.com/63b736b52a58abd71e614cd0d2e69c9ecb2d7b3a
Cr-Commit-Position: refs/heads/master@{#439593}

[juncai, 2016-12-15 20:21:42]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 20:22:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-12-15 20:30:33]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 20:30:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 21:00:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 21:00:09]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[juncai, 2016-12-15 22:34:22]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:35:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-12-15 22:46:46]

juncai@chromium.org changed reviewers:
+ scheib@chromium.org

[juncai, 2016-12-15 22:46:46]

Please take a look.

[commit-bot: I haz the power, 2016-12-16 03:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 03:22:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-12-16 06:36:16]

LGTM

https://codereview.chromium.org/2577183002/diff/40001/chrome/browser/ui/bluet...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2577183002/diff/40001/chrome/browser/ui/bluet...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:127: if
(!accept_all_devices_)
Perhaps move the if check to the Record method?

[juncai, 2016-12-16 18:20:11]

Description was changed from

==========
Add UMA for the number of devices in the chooser when a device is paired

In the case of not accepting all devices in the options that are given
to WebBluetooth requestDevice(), knowing the number of devices that are
in the chooser is helpful for researching some methods to distinguish
devices with the same name. This CL adds UMA for the number of devices
that are in the chooser a device is paired.

BUG=674195
==========

to

==========
Add UMA for the number of devices in the chooser when a device is paired

In the case of not accepting all devices in the options that are given
to WebBluetooth requestDevice(), knowing the number of devices that are
in the chooser is helpful for researching some methods to distinguish
devices with the same name. This CL adds UMA for the number of devices
that are in the chooser when a device is paired.

BUG=674195
==========

[juncai, 2016-12-16 18:23:11]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 18:24:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-12-16 18:34:39]

juncai@chromium.org changed reviewers:
+ isherman@chromium.org, jam@chromium.org, reillyg@chromium.org,
tedchoc@chromium.org

[juncai, 2016-12-16 18:34:40]

tedchoc@chromium.org: Please review changes in 
//chrome/browser/android

reillyg@chromium.org: Please review changes in 
//chrome/browser/extensions
//extensions/browser

jam@chromium.org: Please review changes in 
//chrome/browser/ui/browser.cc
//chrome/browser/ui/browser.h
//content

isherman@chromium.org: Please review changes in 
//tools/metrics/histograms/histograms.xml

https://codereview.chromium.org/2577183002/diff/40001/chrome/browser/ui/bluet...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2577183002/diff/40001/chrome/browser/ui/bluet...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:127: if
(!accept_all_devices_)
On 2016/12/16 06:36:16, scheib wrote:
> Perhaps move the if check to the Record method?

Done.

[Reilly Grant (use Gerrit), 2016-12-16 21:23:20]

You would save a lot of plumbing if you implemented this entirely within
content/browser/bluetooth/bluetooth_device_chooser_controller.cc.

[commit-bot: I haz the power, 2016-12-16 22:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 22:21:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ilya Sherman, 2016-12-17 01:05:45]

https://codereview.chromium.org/2577183002/diff/60001/chrome/browser/ui/bluet...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2577183002/diff/60001/chrome/browser/ui/bluet...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:40: num_of_devices);
Please cap the value that can be recorded here to something reasonable, like
100.

[juncai, 2016-12-19 20:16:10]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 20:16:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-12-19 20:17:48]

On 2016/12/16 21:23:20, Reilly Grant wrote:
> You would save a lot of plumbing if you implemented this entirely within
> content/browser/bluetooth/bluetooth_device_chooser_controller.cc.

Done.

[juncai, 2016-12-19 20:17:57]

https://codereview.chromium.org/2577183002/diff/60001/chrome/browser/ui/bluet...
File chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc (right):

https://codereview.chromium.org/2577183002/diff/60001/chrome/browser/ui/bluet...
chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc:40: num_of_devices);
On 2016/12/17 01:05:45, Ilya Sherman wrote:
> Please cap the value that can be recorded here to something reasonable, like
> 100.

Done.

[Reilly Grant (use Gerrit), 2016-12-19 20:52:17]

lgtm

https://codereview.chromium.org/2577183002/diff/100001/content/browser/blueto...
File content/browser/bluetooth/bluetooth_device_chooser_controller.cc (right):

https://codereview.chromium.org/2577183002/diff/100001/content/browser/blueto...
content/browser/bluetooth/bluetooth_device_chooser_controller.cc:433:
device_ids_.insert(device_id);
I was going to note that you should call device_ids_.erase() whenever you call
BluetoothChooser::RemoveDevice() but then noticed that there is no code that
calls that function, so I suggest removing it in a follow-up patch.

[Ilya Sherman, 2016-12-19 20:59:12]

metrics lgtm, thanks

[commit-bot: I haz the power, 2016-12-19 22:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 22:14:40]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-12-19 22:16:13]

https://codereview.chromium.org/2577183002/diff/100001/content/browser/blueto...
File content/browser/bluetooth/bluetooth_device_chooser_controller.cc (right):

https://codereview.chromium.org/2577183002/diff/100001/content/browser/blueto...
content/browser/bluetooth/bluetooth_device_chooser_controller.cc:433:
device_ids_.insert(device_id);
On 2016/12/19 20:52:17, Reilly Grant wrote:
> I was going to note that you should call device_ids_.erase() whenever you call
> BluetoothChooser::RemoveDevice() but then noticed that there is no code that
> calls that function, so I suggest removing it in a follow-up patch.

Thanks! I filed a bug for it:
https://bugs.chromium.org/p/chromium/issues/detail?id=675720

[juncai, 2016-12-19 22:16:27]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-12-19 22:16:28]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2577183002/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-19 22:17:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 22:25:43]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482185787665000,
"parent_rev": "515fc247d336afe78768b4beea206c428841e90b", "commit_rev":
"88b56fdd04063f1bbe6468bb01c8fc44ad09a11d"}

[commit-bot: I haz the power, 2016-12-19 22:26:18]

Description was changed from

==========
Add UMA for the number of devices in the chooser when a device is paired

In the case of not accepting all devices in the options that are given
to WebBluetooth requestDevice(), knowing the number of devices that are
in the chooser is helpful for researching some methods to distinguish
devices with the same name. This CL adds UMA for the number of devices
that are in the chooser when a device is paired.

BUG=674195
==========

to

==========
Add UMA for the number of devices in the chooser when a device is paired

In the case of not accepting all devices in the options that are given
to WebBluetooth requestDevice(), knowing the number of devices that are
in the chooser is helpful for researching some methods to distinguish
devices with the same name. This CL adds UMA for the number of devices
that are in the chooser when a device is paired.

BUG=674195

Review-Url: https://codereview.chromium.org/2577183002
==========

[commit-bot: I haz the power, 2016-12-19 22:26:20]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-19 22:29:23]

Description was changed from

==========
Add UMA for the number of devices in the chooser when a device is paired

In the case of not accepting all devices in the options that are given
to WebBluetooth requestDevice(), knowing the number of devices that are
in the chooser is helpful for researching some methods to distinguish
devices with the same name. This CL adds UMA for the number of devices
that are in the chooser when a device is paired.

BUG=674195

Review-Url: https://codereview.chromium.org/2577183002
==========

to

==========
Add UMA for the number of devices in the chooser when a device is paired

In the case of not accepting all devices in the options that are given
to WebBluetooth requestDevice(), knowing the number of devices that are
in the chooser is helpful for researching some methods to distinguish
devices with the same name. This CL adds UMA for the number of devices
that are in the chooser when a device is paired.

BUG=674195

Committed: https://crrev.com/63b736b52a58abd71e614cd0d2e69c9ecb2d7b3a
Cr-Commit-Position: refs/heads/master@{#439593}
==========

[commit-bot: I haz the power, 2016-12-19 22:29:24]

Patchset 6 (id:??) landed as
https://crrev.com/63b736b52a58abd71e614cd0d2e69c9ecb2d7b3a
Cr-Commit-Position: refs/heads/master@{#439593}