Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2577173002: [Cronet] Use use_partition_alloc GN arg in Cronet (Closed)

Created:
4 years ago by xunjieli
Modified:
4 years ago
Reviewers:
mef, Paweł Hajdan Jr.
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Use use_partition_alloc GN arg in Cronet Use use_partition_alloc=false GN arg in Cronet BUG=674570 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/f405a0b4e2d49c05f2d6d9b05aa620a72647c917 Cr-Commit-Position: refs/heads/master@{#439477}

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/cronet/tools/cr_cronet.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
xunjieli
phajdan.jr PTAL at mb_config.pyl mef@ PTAL at cr_cronet.py Thanks!
4 years ago (2016-12-15 19:49:31 UTC) #4
mef
lgtm
4 years ago (2016-12-15 20:07:36 UTC) #5
Paweł Hajdan Jr.
LGTM
4 years ago (2016-12-16 20:15:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577173002/20001
4 years ago (2016-12-16 20:16:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/87920)
4 years ago (2016-12-16 22:30:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577173002/20001
4 years ago (2016-12-19 14:13:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 15:17:51 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-19 15:20:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f405a0b4e2d49c05f2d6d9b05aa620a72647c917
Cr-Commit-Position: refs/heads/master@{#439477}

Powered by Google App Engine
This is Rietveld 408576698