arc: Rename methods in ArcSessionManager::Observer.

chrome/browser/chromeos/arc/arc_session_manager.h

Index: chrome/browser/chromeos/arc/arc_session_manager.h
diff --git a/chrome/browser/chromeos/arc/arc_session_manager.h b/chrome/browser/chromeos/arc/arc_session_manager.h
index 5c6a16e759de31556166ac3b5dbf846a999b6347..3c432a73647751e6809f0f81c4ef473594537675 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager.h
+++ b/chrome/browser/chromeos/arc/arc_session_manager.h
@@ -103,13 +103,13 @@ class ArcSessionManager : public ArcService,
     virtual ~Observer() = default;
 
     // Called to notify that ARC bridge is shut down.
-    virtual void OnShutdownBridge() {}
+    virtual void OnArcShutdownBridge() {}

[Luis Héctor Chávez, 2016/12/15 18:10:39]

nit: the other methods use OnArcNounVerb() pattern. Can you rename this to
OnArcBridgeShutdown()?

[Daniel Erat, 2016/12/15 18:15:33]

sure. thoughts about going with "OnArcBridgeShutDown" instead? "shut down" is
the verb form, while "shutdown" is the noun, although chrome incorrectly uses
"shutdown" as a verb in a bunch of places. OnArcInitialStart also seems to be
ending with a noun, though, so i'm okay with keeping "shutdown" here too.

[Luis Héctor Chávez, 2016/12/15 18:21:51]

Yeah, I was hesitant to add the comment about OnArcInitialStart because there
wasn't a name that was clearly better without sounding too forced :/

I agree with you that ShutDown is more correct, bue given that there are 402
instances of Shutdown in chrome/ and only 2 of ShutDown, this would look out of
place if we went with the latter (kind of like with HTTP's Referer).

 
     // Called to notify that ARC enabled state has been updated.
-    virtual void OnOptInEnabled(bool enabled) {}
+    virtual void OnArcOptInChanged(bool enabled) {}
 
     // Called to notify that ARC has been initialized successfully.
-    virtual void OnInitialStart() {}
+    virtual void OnArcInitialStart() {}
 
     // Called to notify that Android data has been removed. Used in
     // browser_tests