arc: Rename methods in ArcSessionManager::Observer.

chrome/browser/chromeos/arc/arc_session_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 85 matching lines @@
     CHECKING_ANDROID_MANAGEMENT,
     REMOVING_DATA_DIR,
     ACTIVE,
   };
 
   class Observer {
    public:
     virtual ~Observer() = default;
 
     // Called to notify that ARC bridge is shut down.
-    virtual void OnShutdownBridge() {}
+    virtual void OnArcShutdownBridge() {}

[Luis Héctor Chávez, 2016/12/15 18:10:39]

nit: the other methods use OnArcNounVerb() pattern. Can you rename this to
OnArcBridgeShutdown()?

[Daniel Erat, 2016/12/15 18:15:33]

sure. thoughts about going with "OnArcBridgeShutDown" instead? "shut down" is
the verb form, while "shutdown" is the noun, although chrome incorrectly uses
"shutdown" as a verb in a bunch of places. OnArcInitialStart also seems to be
ending with a noun, though, so i'm okay with keeping "shutdown" here too.

[Luis Héctor Chávez, 2016/12/15 18:21:51]

Yeah, I was hesitant to add the comment about OnArcInitialStart because there
wasn't a name that was clearly better without sounding too forced :/

I agree with you that ShutDown is more correct, bue given that there are 402
instances of Shutdown in chrome/ and only 2 of ShutDown, this would look out of
place if we went with the latter (kind of like with HTTP's Referer).

 
     // Called to notify that ARC enabled state has been updated.
-    virtual void OnOptInEnabled(bool enabled) {}
+    virtual void OnArcOptInChanged(bool enabled) {}
 
     // Called to notify that ARC has been initialized successfully.
-    virtual void OnInitialStart() {}
+    virtual void OnArcInitialStart() {}
 
     // Called to notify that Android data has been removed. Used in
     // browser_tests
     virtual void OnArcDataRemoved() {}
   };
 
   explicit ArcSessionManager(ArcBridgeService* bridge_service);
   ~ArcSessionManager() override;
 
   static ArcSessionManager* Get();
@@ skipping 140 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ArcSessionManager);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os,
                          const ArcSessionManager::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_