Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2577073004: Resurrect ImageResourceTest and MultipartImageResourceParserTest (Closed)

Created:
4 years ago by hiroshige
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resurrect ImageResourceTest and MultipartImageResourceParserTest ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they have not been compiled and executed. This CL resurrects these entries in BUILD.gn and thus re-enabling these tests. BUG=655920 Committed: https://crrev.com/d3d655ba26ec0573d15cfaefb6d05af09e16e484 Cr-Commit-Position: refs/heads/master@{#439347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (14 generated)
hiroshige
PTAL. Fortunately, the tests compile and run successfully without changes, so there seem no regressions ...
4 years ago (2016-12-16 20:23:01 UTC) #5
haraken
LGTM
4 years ago (2016-12-17 01:47:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577073004/1
4 years ago (2016-12-17 02:02:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88256)
4 years ago (2016-12-17 04:28:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577073004/1
4 years ago (2016-12-17 06:40:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88292)
4 years ago (2016-12-17 08:02:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577073004/1
4 years ago (2016-12-17 18:19:46 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 18:53:55 UTC) #21
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d3d655ba26ec0573d15cfaefb6d05af09e16e484 Cr-Commit-Position: refs/heads/master@{#439347}
4 years ago (2016-12-17 18:57:44 UTC) #23
kouhei (in TOK)
4 years ago (2016-12-19 01:39:03 UTC) #24
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698