|
|
DescriptionResurrect ImageResourceTest and MultipartImageResourceParserTest
ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed
from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they
have not been compiled and executed.
This CL resurrects these entries in BUILD.gn and thus re-enabling these tests.
BUG=655920
Committed: https://crrev.com/d3d655ba26ec0573d15cfaefb6d05af09e16e484
Cr-Commit-Position: refs/heads/master@{#439347}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 24 (14 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Resurrect ImageResourceTest and MultipartImageResourceParserTest.cpp BUG= ========== to ========== Resurrect ImageResourceTest and MultipartImageResourceParserTest ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they have not been compiled and executed. This CL resurrects these entries in BUILD.gn and thus re-enabling these tests. BUG=655920 ==========
hiroshige@chromium.org changed reviewers: + haraken@chromium.org, kouhei@chromium.org, toyoshim@chromium.org, yhirano@chromium.org
PTAL. Fortunately, the tests compile and run successfully without changes, so there seem no regressions while they are unintentionally disabled.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
LGTM
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481998774110400, "parent_rev": "09ba49867c0c97dc5a32b37c72b97a204ff51166", "commit_rev": "6dc264c71caa0508c0a9cc9eba854dd082bca2be"}
Message was sent while issue was closed.
Description was changed from ========== Resurrect ImageResourceTest and MultipartImageResourceParserTest ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they have not been compiled and executed. This CL resurrects these entries in BUILD.gn and thus re-enabling these tests. BUG=655920 ========== to ========== Resurrect ImageResourceTest and MultipartImageResourceParserTest ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they have not been compiled and executed. This CL resurrects these entries in BUILD.gn and thus re-enabling these tests. BUG=655920 Review-Url: https://codereview.chromium.org/2577073004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Resurrect ImageResourceTest and MultipartImageResourceParserTest ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they have not been compiled and executed. This CL resurrects these entries in BUILD.gn and thus re-enabling these tests. BUG=655920 Review-Url: https://codereview.chromium.org/2577073004 ========== to ========== Resurrect ImageResourceTest and MultipartImageResourceParserTest ImageResourceTest.cpp and MultipartImageResourceParserTest.cpp were removed from BUILD.gn by https://codereview.chromium.org/2558033002/ and thus they have not been compiled and executed. This CL resurrects these entries in BUILD.gn and thus re-enabling these tests. BUG=655920 Committed: https://crrev.com/d3d655ba26ec0573d15cfaefb6d05af09e16e484 Cr-Commit-Position: refs/heads/master@{#439347} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d3d655ba26ec0573d15cfaefb6d05af09e16e484 Cr-Commit-Position: refs/heads/master@{#439347}
Message was sent while issue was closed.
lgtm |