Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2577063003: [MediaNotification] Fix a button computation issue with PLAY_PAUSE (Closed)

Created:
4 years ago by Zhiqiang Zhang (Slow)
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaNotification] Fix a button computation issue with PLAY_PAUSE This CL fixes an issue which PLAY_PAUSE is not removed before computing buttons that need to be shown in the notification. As PLAY_PAUSE action is going to be removed shortly, no bug is filed. BUG=None Committed: https://crrev.com/a8262c2c857d2893a99d75b6ed81681741a829e3 Cr-Commit-Position: refs/heads/master@{#439109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Zhiqiang Zhang (Slow)
4 years ago (2016-12-15 21:21:01 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years ago (2016-12-16 14:26:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577063003/1
4 years ago (2016-12-16 14:33:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 15:25:49 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-16 15:29:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8262c2c857d2893a99d75b6ed81681741a829e3
Cr-Commit-Position: refs/heads/master@{#439109}

Powered by Google App Engine
This is Rietveld 408576698