Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2577043004: Include temporary variables in --print-scopes output (Closed)

Created:
4 years ago by adamk
Modified:
4 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include temporary variables in --print-scopes output R=neis@chromium.org BUG=v8:5743 Review-Url: https://codereview.chromium.org/2577043004 Cr-Commit-Position: refs/heads/master@{#41726} Committed: https://chromium.googlesource.com/v8/v8/+/45d51734c973f517335f1240b9a85dd175d5288b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/ast/scopes.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
adamk
4 years ago (2016-12-15 14:36:39 UTC) #1
neis
lgtm
4 years ago (2016-12-15 14:40:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577043004/1
4 years ago (2016-12-15 14:42:03 UTC) #4
commit-bot: I haz the power
4 years ago (2016-12-15 15:12:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/45d51734c973f517335f1240b9a85dd175d...

Powered by Google App Engine
This is Rietveld 408576698