Fix content settings for hosted apps not displayed correctly.

Fix content settings for hosted apps not displayed correctly after change from http://crrev.com/2525943002. I also changed GetChooserExceptionForPage() to have a displayName to be consistent with the other exception objects.

BUG=671547
Committed: https://crrev.com/83f0c6183d9cdbad6ec74a55dae7d855a5860791
Cr-Commit-Position: refs/heads/master@{#439757}

[dullweber, 2016-12-15 12:28:33]

Description was changed from

==========
Fix content settings for hosted apps not displayed correctly.

BUG=671547
==========

to

==========
Fix content settings for hosted apps not displayed correctly after change from
http://crrev.com/2525943002.

BUG=671547
==========

[dullweber, 2016-12-15 12:28:55]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 12:29:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2016-12-15 12:32:05]

Description was changed from

==========
Fix content settings for hosted apps not displayed correctly after change from
http://crrev.com/2525943002.

BUG=671547
==========

to

==========
Fix content settings for hosted apps not displayed correctly after change from
http://crrev.com/2525943002. I also changed GetChooserExceptionForPage() to have
a displayName to be consistent with the other exception objects.

BUG=671547
==========

[dullweber, 2016-12-15 12:34:10]

dullweber@chromium.org changed reviewers:
+ dbeam@chromium.org

[dullweber, 2016-12-15 12:34:11]

Dan, please review this small fix

[commit-bot: I haz the power, 2016-12-15 16:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 16:30:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-12-16 01:43:04]

dbeam@chromium.org changed reviewers:
+ dschuyler@chromium.org

[Dan Beam, 2016-12-16 01:43:05]

+dschuyler@

is there a test you could update somewhere?

[dullweber, 2016-12-16 08:48:24]

On 2016/12/16 01:43:05, Dan Beam wrote:
> +dschuyler@
> 
> is there a test you could update somewhere?

I updated the SiteSettingsHelper and SiteSettingsHandler unittests to verify
that kDisplayName is set for normal exceptions and exceptions from hosted apps.

[dullweber, 2016-12-16 09:08:50]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 09:09:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 09:53:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 09:53:47]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-12-20 02:33:57]

I'm generally in favor of setting the device name from C++ (rather than trying
to figure it out in JavaScript), thanks for doing this. lgtm

[Dan Beam, 2016-12-20 06:07:53]

lgtm

[dullweber, 2016-12-20 08:16:08]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2016-12-20 08:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 09:11:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482221768765540,
"parent_rev": "686f6f3da6de5f84a98dd84358d853239b26ab2c", "commit_rev":
"91c3977f28b56efa2f60e99b316d19c9d0244ae8"}

[commit-bot: I haz the power, 2016-12-20 09:12:28]

Description was changed from

==========
Fix content settings for hosted apps not displayed correctly after change from
http://crrev.com/2525943002. I also changed GetChooserExceptionForPage() to have
a displayName to be consistent with the other exception objects.

BUG=671547
==========

to

==========
Fix content settings for hosted apps not displayed correctly after change from
http://crrev.com/2525943002. I also changed GetChooserExceptionForPage() to have
a displayName to be consistent with the other exception objects.

BUG=671547

Review-Url: https://codereview.chromium.org/2577043002
==========

[commit-bot: I haz the power, 2016-12-20 09:12:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 09:15:54]

Description was changed from

==========
Fix content settings for hosted apps not displayed correctly after change from
http://crrev.com/2525943002. I also changed GetChooserExceptionForPage() to have
a displayName to be consistent with the other exception objects.

BUG=671547

Review-Url: https://codereview.chromium.org/2577043002
==========

to

==========
Fix content settings for hosted apps not displayed correctly after change from
http://crrev.com/2525943002. I also changed GetChooserExceptionForPage() to have
a displayName to be consistent with the other exception objects.

BUG=671547

Committed: https://crrev.com/83f0c6183d9cdbad6ec74a55dae7d855a5860791
Cr-Commit-Position: refs/heads/master@{#439757}
==========

[commit-bot: I haz the power, 2016-12-20 09:15:55]

Patchset 2 (id:??) landed as
https://crrev.com/83f0c6183d9cdbad6ec74a55dae7d855a5860791
Cr-Commit-Position: refs/heads/master@{#439757}