Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2734)

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.html

Issue 2577003002: MD Settings: actually fix sync Learn More click issues (Closed)
Patch Set: closure Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/sync_page.html
diff --git a/chrome/browser/resources/settings/people_page/sync_page.html b/chrome/browser/resources/settings/people_page/sync_page.html
index a55fdd349dc732d4d6b61858b80307eafbc98eba..b502be0ce5e96ce7634e914599e8a8093ff0db1c 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.html
+++ b/chrome/browser/resources/settings/people_page/sync_page.html
@@ -187,7 +187,9 @@
<span>[[syncPrefs.fullEncryptionBody]]</span>
</template>
<template is="dom-if" if="[[!syncPrefs.fullEncryptionBody]]">
- <span>$i18nRaw{encryptWithSyncPassphraseLabel}</span>
+ <span on-tap="onLearnMoreTap_">
tommycli 2016/12/15 16:08:33 probably rename this: onControlLabelTap_ or onLabe
Dan Beam 2016/12/16 01:24:39 ehhhh
+ $i18nRaw{encryptWithSyncPassphraseLabel}
+ </span>
</template>
</paper-radio-button>
</paper-radio-group>
@@ -228,8 +230,7 @@
<div class="list-item">
<span>
[[enterPassphrasePrompt_(syncPrefs.passphraseTypeIsCustom)]]
- <a href="$i18nRaw{syncErrorHelpUrl}" target="_blank"
- on-tap="onSyncLearnMoreTap_">
+ <a href="$i18nRaw{syncErrorHelpUrl}" target="_blank">
$i18n{learnMore}
</a>
</span>

Powered by Google App Engine
This is Rietveld 408576698