MD Settings: actually fix sync Learn More click issues

chrome/browser/resources/settings/people_page/sync_page.html

 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/paper-radio-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/paper-radio-group.html">
 <link rel="import" href="/people_page/sync_browser_proxy.html">
 <link rel="import" href="/route.html">
@@ skipping 169 matching lines @@
           <paper-radio-button name="encrypt-with-google"
               class="list-item" disabled="[[syncPrefs.encryptAllData]]">
             $i18n{encryptWithGoogleCredentialsLabel}
           </paper-radio-button>
           <paper-radio-button name="encrypt-with-passphrase"
               class="list-item" disabled="[[syncPrefs.encryptAllData]]">
             <template is="dom-if" if="[[syncPrefs.fullEncryptionBody]]">
               <span>[[syncPrefs.fullEncryptionBody]]</span>
             </template>
             <template is="dom-if" if="[[!syncPrefs.fullEncryptionBody]]">
-              <span>$i18nRaw{encryptWithSyncPassphraseLabel}</span>
+              <span on-tap="onLearnMoreTap_">

[tommycli, 2016/12/15 16:08:33]

probably rename this: onControlLabelTap_ or onLabelTap_

[Dan Beam, 2016/12/16 01:24:39]

ehhhh

+                $i18nRaw{encryptWithSyncPassphraseLabel}
+              </span>
             </template>
           </paper-radio-button>
         </paper-radio-group>
         <div id="reset-sync-message-box" class="list-item"
             hidden="[[!syncPrefs.encryptAllData]]">
           <span>$i18nRaw{passphraseResetHint}</span>
         </div>
       </div>
 
       <template is="dom-if" if="[[creatingNewPassphrase_]]">
@@ skipping 20 matching lines @@
             </paper-button>
           </div>
         </div>
       </template>
 
       <template is="dom-if" if="[[syncPrefs.passphraseRequired]]">
         <div class="list-frame">
           <div class="list-item">
             <span>
               [[enterPassphrasePrompt_(syncPrefs.passphraseTypeIsCustom)]]
-              <a href="$i18nRaw{syncErrorHelpUrl}" target="_blank"
-                  on-tap="onSyncLearnMoreTap_">
+              <a href="$i18nRaw{syncErrorHelpUrl}" target="_blank">
                 $i18n{learnMore}
               </a>
             </span>
           </div>
           <div id="existingPassphraseContainer" class="list-item">
             <paper-input id="existingPassphraseInput" type="password"
                 value="{{existingPassphrase_}}"
                 placeholder="$i18n{passphrasePlaceholder}"
                 error-message="$i18n{incorrectPassphraseError}">
             </paper-input>
             <paper-button id="submitExistingPassphrase"
                 on-tap="onSubmitExistingPassphraseTap_" class="action-button"
                 disabled="[[!existingPassphrase_]]">
               $i18n{submitPassphraseButton}
             </paper-button>
           </div>
           <div id="passphraseRecoverHint" class="list-item">
             <span>$i18nRaw{passphraseRecover}</span>
           </div>
         </div>
       </template>
     </div>
   </template>
   <script src="sync_page.js"></script>
 </dom-module>