Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2576983004: [DevTools] Avoid assertion failure (Closed)

Created:
4 years ago by eostroukhov
Modified:
4 years ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Avoid assertion failure Pressing Ctrl+Enter in a regualr source value attempts to run a snippet, failing an assertion and showing red squiggles under the selected source line. BUG=None Committed: https://crrev.com/0e643e7bcf73e2d29d6e7f2e36b9b7352b3e62bb Cr-Commit-Position: refs/heads/master@{#438999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
eostroukhov
Please take a look.
4 years ago (2016-12-15 23:05:49 UTC) #4
dgozman
lgtm. Sorry, that's my regresison.
4 years ago (2016-12-15 23:09:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576983004/1
4 years ago (2016-12-15 23:14:34 UTC) #8
lushnikov
that's hilarious. lgtm!
4 years ago (2016-12-15 23:28:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 03:17:45 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 03:20:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e643e7bcf73e2d29d6e7f2e36b9b7352b3e62bb
Cr-Commit-Position: refs/heads/master@{#438999}

Powered by Google App Engine
This is Rietveld 408576698