Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2576983003:
Remove startup metrics recorded 7 minutes after system start. (Closed)
DescriptionRemove startup metrics recorded 7 minutes after system start.
Startup metrics can be sent only first 7 minutes from system start,
while expected these metrics will be sent only if 7 minutes are passed
from system start.
Since M54 hit stable, drop these metrics.
BUG=634408
R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org
Committed: https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31
Cr-Commit-Position: refs/heads/master@{#439343}
Patch Set 1 #Patch Set 2 : Removed startup metrics which are sent only if 7 minutes uptime is passed. #Patch Set 3 : Modified histograms.xml #
Messages
Total messages: 26 (14 generated)
Good catch! However, we planned to remove these histograms once M54 hit stable and we are now shipping M55 on stable https://omahaproxy.appspot.com/. Can you instead remove all histograms that are supposed to be removed after 7 minutes of OS uptime? Thanks!
On 2016/12/15 16:28:41, fdoray wrote: > Good catch! > > However, we planned to remove these histograms once M54 hit stable and we are > now shipping M55 on stable https://omahaproxy.appspot.com/. Can you instead > remove all histograms that are supposed to be removed after 7 minutes of OS > uptime? > > Thanks! done.
Description was changed from ========== Startup metriscs can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. BUG= R=fdoray@chromium.org, gab@chromium.org ========== to ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. BUG= R=fdoray@chromium.org, gab@chromium.org ==========
gab@chromium.org changed reviewers: - gab@chromium.org
gab@chromium.org changed reviewers: + gab@chromium.org
Moving self to CC, Friday is sufficient here
Looks good! CL title: Change to "Remove startup metrics recorded 7 minutes after system start." You'll also need to add an <obsolete> tag and remove TODOs for the removed histograms in tools/metrics/histograms/histograms.xml You'll need a review from someone in tools/metrics/OWNERS for your histograms.xml changes.
Description was changed from ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. BUG= R=fdoray@chromium.org, gab@chromium.org ========== to ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG= R=fdoray@chromium.org, gab@chromium.org ==========
Description was changed from ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG= R=fdoray@chromium.org, gab@chromium.org ========== to ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org ==========
Description was changed from ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org ========== to ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, asvitkine@chromium.org ==========
Description was changed from ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, asvitkine@chromium.org ========== to ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, asvitkine@chromium.org, isherman@chromium.org ==========
On 2016/12/16 14:07:32, fdoray wrote: > Looks good! > > CL title: Change to "Remove startup metrics recorded 7 minutes after system > start." > > You'll also need to add an <obsolete> tag and remove TODOs for the removed > histograms in tools/metrics/histograms/histograms.xml > > You'll need a review from someone in tools/metrics/OWNERS for your > histograms.xml changes. Modified description, histogram.xml, added reviewers for histogram.xml
Description was changed from ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, asvitkine@chromium.org, isherman@chromium.org ========== to ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org ==========
palar@yandex-team.ru changed reviewers: + isherman@chromium.org
On 2016/12/16 14:38:47, palar wrote: > Modified description, histogram.xml, added reviewers for histogram.xml oops. another try.
lgtm Change the first line of the CL description to "Remove startup metrics recorded 7 minutes after system start."
Description was changed from ========== Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org ========== to ========== Remove startup metrics recorded 7 minutes after system start. Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org ==========
LGTM, thanks!
The CQ bit was checked by palar@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481980069318210,
"parent_rev": "b46b5b8f8401ab706c06b97517f8e3606bf4f29b", "commit_rev":
"acc4a2a4a7dfbaea3b07912c1430065155673959"}
Message was sent while issue was closed.
Description was changed from ========== Remove startup metrics recorded 7 minutes after system start. Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org ========== to ========== Remove startup metrics recorded 7 minutes after system start. Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org Review-Url: https://codereview.chromium.org/2576983003 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove startup metrics recorded 7 minutes after system start. Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org Review-Url: https://codereview.chromium.org/2576983003 ========== to ========== Remove startup metrics recorded 7 minutes after system start. Startup metrics can be sent only first 7 minutes from system start, while expected these metrics will be sent only if 7 minutes are passed from system start. Since M54 hit stable, drop these metrics. BUG=634408 R=fdoray@chromium.org, gab@chromium.org, isherman@chromium.org Committed: https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31 Cr-Commit-Position: refs/heads/master@{#439343} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/62f7d4ca915fbad122d81109806e2409bd383a31 Cr-Commit-Position: refs/heads/master@{#439343} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
