Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2576903004:
ThreadTicks::Now support for Solaris (Closed)
|
Created:
4 years ago by mattloring Modified:
4 years ago CC:
fmeawad, v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionThreadTicks::Now support for Solaris
BUG=v8:5739
Review-Url: https://codereview.chromium.org/2576903004
Cr-Commit-Position: refs/heads/master@{#41771}
Committed: https://chromium.googlesource.com/v8/v8/+/081fce326f397a1be26224e51e1ccd3f35300ed6
Patch Set 1 #
Total comments: 2
Messages
Total messages: 29 (19 generated)
mattloring@google.com changed reviewers: + jochen@chromium.org, lpy@chromium.org
The CQ bit was checked by mattloring@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. Please also make sure it won't break V8 build. https://codereview.chromium.org/2576903004/diff/1/src/base/platform/time.cc File src/base/platform/time.cc (right): https://codereview.chromium.org/2576903004/diff/1/src/base/platform/time.cc#n... src/base/platform/time.cc:642: defined(V8_OS_MACOSX) || defined(V8_OS_ANDROID) || defined(V8_OS_SOLARIS) please correct the indentation, not sure how `git cl format` will show it.
https://codereview.chromium.org/2576903004/diff/1/src/base/platform/time.cc File src/base/platform/time.cc (right): https://codereview.chromium.org/2576903004/diff/1/src/base/platform/time.cc#n... src/base/platform/time.cc:642: defined(V8_OS_MACOSX) || defined(V8_OS_ANDROID) || defined(V8_OS_SOLARIS) On 2016/12/15 20:05:14, lpy wrote: > please correct the indentation, not sure how `git cl format` will show it. This was the result of a git cl format. I can revert it to the old style for consistency.
On 2016/12/15 20:07:45, mattloring wrote: > https://codereview.chromium.org/2576903004/diff/1/src/base/platform/time.cc > File src/base/platform/time.cc (right): > > https://codereview.chromium.org/2576903004/diff/1/src/base/platform/time.cc#n... > src/base/platform/time.cc:642: defined(V8_OS_MACOSX) || defined(V8_OS_ANDROID) > || defined(V8_OS_SOLARIS) > On 2016/12/15 20:05:14, lpy wrote: > > please correct the indentation, not sure how `git cl format` will show it. > > This was the result of a git cl format. I can revert it to the old style for > consistency. Cool, let's follow `git cl format`, thanks for the clarification.
Description was changed from ========== ThreadTicks::Now support for Solaris BUG=v8:5739 ========== to ========== ThreadTicks::Now support for Solaris BUG=v8:5739 ==========
mattloring@google.com changed reviewers: + ofrobots@google.com
On 2016/12/15 20:09:07, lpy wrote: > On 2016/12/15 20:07:45, mattloring wrote: > > https://codereview.chromium.org/2576903004/diff/1/src/base/platform/time.cc > > File src/base/platform/time.cc (right): > > > > > https://codereview.chromium.org/2576903004/diff/1/src/base/platform/time.cc#n... > > src/base/platform/time.cc:642: defined(V8_OS_MACOSX) || defined(V8_OS_ANDROID) > > || defined(V8_OS_SOLARIS) > > On 2016/12/15 20:05:14, lpy wrote: > > > please correct the indentation, not sure how `git cl format` will show it. > > > > This was the result of a git cl format. I can revert it to the old style for > > consistency. > > Cool, let's follow `git cl format`, thanks for the clarification. LGTM.
The CQ bit was checked by mattloring@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30721)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by mattloring@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mattloring@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30725)
lgtm
The CQ bit was checked by mattloring@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481903995061070, "parent_rev":
"3f5a60ac17dc1e84bfda6429cc69f7497ed3ea24", "commit_rev":
"081fce326f397a1be26224e51e1ccd3f35300ed6"}
Message was sent while issue was closed.
Description was changed from ========== ThreadTicks::Now support for Solaris BUG=v8:5739 ========== to ========== ThreadTicks::Now support for Solaris BUG=v8:5739 Review-Url: https://codereview.chromium.org/2576903004 Cr-Commit-Position: refs/heads/master@{#41771} Committed: https://chromium.googlesource.com/v8/v8/+/081fce326f397a1be26224e51e1ccd3f353... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/081fce326f397a1be26224e51e1ccd3f353... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
