Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2576893002: Return unique_ptr from CXFA_FFApp::CreateDoc. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Return unique_ptr from CXFA_FFApp::CreateDoc. Remove one unused CreateDoc variant. Review-Url: https://codereview.chromium.org/2576893002 Committed: https://pdfium.googlesource.com/pdfium/+/37b12ad873198a9644f3de0d2eff001285e1ad42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M fpdfsdk/fpdfview.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_context.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 chunk +7 lines, -11 lines 0 comments Download
M xfa/fxfa/xfa_ffapp.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, ready for review.
4 years ago (2016-12-14 22:51:26 UTC) #2
dsinclair
lgtm
4 years ago (2016-12-15 03:50:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576893002/1
4 years ago (2016-12-15 03:50:12 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-15 03:50:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/37b12ad873198a9644f3de0d2eff001285e1...

Powered by Google App Engine
This is Rietveld 408576698