Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9102)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 2576833002: Make some updates to extension iconography. (Closed)
Patch Set: add test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
index 0e2b5bede13f0a449e4b3e963808aac13416d65c..42dd7b55402a79420098cded4c1b89ee92d74f9b 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
@@ -160,25 +160,12 @@ void AppLauncherHandler::CreateAppInfo(
service->profile())->management_policy()->UserMayModifySettings(
extension, NULL));
- bool icon_big_exists = true;
// Instead of setting grayscale here, we do it in apps_page.js.
- GURL icon_big = extensions::ExtensionIconSource::GetIconURL(
- extension,
- extension_misc::EXTENSION_ICON_LARGE,
- ExtensionIconSet::MATCH_BIGGER,
- false,
- &icon_big_exists);
- value->SetString("icon_big", icon_big.spec());
- value->SetBoolean("icon_big_exists", icon_big_exists);
- bool icon_small_exists = true;
- GURL icon_small = extensions::ExtensionIconSource::GetIconURL(
- extension,
- extension_misc::EXTENSION_ICON_BITTY,
- ExtensionIconSet::MATCH_BIGGER,
- false,
- &icon_small_exists);
- value->SetString("icon_small", icon_small.spec());
- value->SetBoolean("icon_small_exists", icon_small_exists);
+ GURL icon = extensions::ExtensionIconSource::GetIconURL(
+ extension, extension_misc::EXTENSION_ICON_LARGE,
+ ExtensionIconSet::MATCH_BIGGER, false);
+ DCHECK_NE(GURL(), icon);
+ value->SetString("icon", icon.spec());
value->SetInteger("launch_container",
extensions::AppLaunchInfo::GetLaunchContainer(extension));
ExtensionPrefs* prefs = ExtensionPrefs::Get(service->profile());

Powered by Google App Engine
This is Rietveld 408576698