Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6413)

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.cc

Issue 2576833002: Make some updates to extension iconography. (Closed)
Patch Set: add test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/omnibox/omnibox_api.cc
diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc
index 5212b3588e7ac17256e4f4820ee2e521b829c72b..d954ed0be435dbf8b36cc135f25ec4d0c7b2dac2 100644
--- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc
+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc
@@ -45,17 +45,6 @@ const char kBackgroundTabDisposition[] = "newBackgroundTab";
// Pref key for omnibox.setDefaultSuggestion.
const char kOmniboxDefaultSuggestion[] = "omnibox_default_suggestion";
-#if defined(OS_LINUX)
-static const int kOmniboxIconPaddingLeft = 2;
-static const int kOmniboxIconPaddingRight = 2;
-#elif defined(OS_MACOSX)
-static const int kOmniboxIconPaddingLeft = 0;
-static const int kOmniboxIconPaddingRight = 2;
-#else
-static const int kOmniboxIconPaddingLeft = 0;
-static const int kOmniboxIconPaddingRight = 0;
-#endif
-
std::unique_ptr<omnibox::SuggestResult> GetOmniboxDefaultSuggestion(
Profile* profile,
const std::string& extension_id) {
@@ -195,10 +184,7 @@ OmniboxAPI::OmniboxAPI(content::BrowserContext* context)
}
// Use monochrome icons for Omnibox icons.
- omnibox_popup_icon_manager_.set_monochrome(true);
omnibox_icon_manager_.set_monochrome(true);
- omnibox_icon_manager_.set_padding(gfx::Insets(0, kOmniboxIconPaddingLeft,
- 0, kOmniboxIconPaddingRight));
}
void OmniboxAPI::Shutdown() {
@@ -226,7 +212,6 @@ void OmniboxAPI::OnExtensionLoaded(content::BrowserContext* browser_context,
const std::string& keyword = OmniboxInfo::GetKeyword(extension);
if (!keyword.empty()) {
// Load the omnibox icon so it will be ready to display in the URL bar.
- omnibox_popup_icon_manager_.LoadIcon(profile_, extension);
omnibox_icon_manager_.LoadIcon(profile_, extension);
if (url_service_) {
@@ -256,13 +241,7 @@ void OmniboxAPI::OnExtensionUnloaded(content::BrowserContext* browser_context,
}
gfx::Image OmniboxAPI::GetOmniboxIcon(const std::string& extension_id) {
- return gfx::Image::CreateFrom1xBitmap(
- omnibox_icon_manager_.GetIcon(extension_id));
-}
-
-gfx::Image OmniboxAPI::GetOmniboxPopupIcon(const std::string& extension_id) {
- return gfx::Image::CreateFrom1xBitmap(
- omnibox_popup_icon_manager_.GetIcon(extension_id));
+ return omnibox_icon_manager_.GetIcon(extension_id);
}
void OmniboxAPI::OnTemplateURLsLoaded() {

Powered by Google App Engine
This is Rietveld 408576698